Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow categorise transfer to off budget accounts on mobile #1824

Conversation

Kit-p
Copy link
Contributor

@Kit-p Kit-p commented Oct 23, 2023

This PR allows categorising transactions to off budget accounts (as payee) when using mobile, in order to align with the behavior when using desktop.

Closes #1822

@netlify
Copy link

netlify bot commented Oct 23, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 25ddae4
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/653615eb4b614000083d0fda
😎 Deploy Preview https://deploy-preview-1824.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Kit-p Kit-p changed the title Allow categorise transfer to off budget accounts Allow categorise transfer to off budget accounts on mobile Oct 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 2.82 MB → 2.82 MB (+14 B) +0.00%
Changeset
File Δ Size
src/components/transactions/MobileTransaction.js 📈 +27 B (+0.05%) 48.89 kB → 48.91 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/main.js 1.12 MB → 1.12 MB (+14 B) +0.00%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/848.chunk.js 760.98 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/444.chunk.js 156.11 kB 0%
static/js/wide-components.chunk.js 126.79 kB 0%
static/js/231.chunk.js 117.37 kB 0%
static/js/narrow-components.chunk.js 42.61 kB 0%
static/js/reports.chunk.js 29.97 kB 0%
static/js/473.chunk.js 13 kB 0%
static/js/312.chunk.js 12.78 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.88 kB 0%
static/css/main.css 7.41 kB 0%
asset-manifest.json 2.07 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 903 B 0%

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.22 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.23 MB 0%
xfo.xfo.kcab.worker.js 1014.46 kB 0%

Copy link
Contributor

@shall0pass shall0pass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@youngcw youngcw merged commit 5fe146e into actualbudget:master Oct 27, 2023
17 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Oct 27, 2023
@Kit-p Kit-p deleted the fix/allow-categorise-transfer-to-off-budget-account branch October 28, 2023 02:02
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
…get#1824)

* Allow categorise transfer to off budget accounts

* Add release notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: mobile - Category is unselectable for transfers between off-budget and on-budget accounts
3 participants