Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page color updates #1799

Merged
merged 3 commits into from
Oct 21, 2023
Merged

Page color updates #1799

merged 3 commits into from
Oct 21, 2023

Conversation

carkom
Copy link
Contributor

@carkom carkom commented Oct 15, 2023

Consolidating and making consistent pagebackground, and pagetext components. Very small changes - in most cases just changiner colors by one single shade (eg. navy600 to navy500)

@netlify
Copy link

netlify bot commented Oct 15, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 4b88c2c
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/6534231d12b87c0008c53cd9
😎 Deploy Preview https://deploy-preview-1799.demo.actualbudget.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2023

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 2.82 MB → 2.82 MB (-578 B) -0.02%
Changeset
File Δ Size
src/components/transactions/TransactionsTable.js 📈 +2 B (+0.00%) 65.78 kB → 65.78 kB
src/components/transactions/MobileTransaction.js 📉 -5 B (-0.01%) 48.86 kB → 48.85 kB
src/components/modals/EditRule.js 📉 -5 B (-0.01%) 36.38 kB → 36.38 kB
src/components/schedules/EditSchedule.js 📉 -10 B (-0.03%) 38.18 kB → 38.17 kB
src/components/budget/report/BudgetSummary.tsx 📉 -5 B (-0.03%) 18.58 kB → 18.58 kB
src/components/autocomplete/PayeeAutocomplete.js 📉 -5 B (-0.03%) 14.84 kB → 14.84 kB
src/components/modals/CreateLocalAccount.tsx 📉 -5 B (-0.06%) 8.66 kB → 8.65 kB
src/components/UpdateNotification.tsx 📉 -3 B (-0.06%) 4.9 kB → 4.89 kB
src/components/budget/BudgetTotals.js 📉 -5 B (-0.10%) 4.69 kB → 4.69 kB
src/components/accounts/MobileAccounts.js 📉 -10 B (-0.11%) 9.22 kB → 9.21 kB
src/components/manager/WelcomeScreen.js 📉 -5 B (-0.13%) 3.82 kB → 3.81 kB
src/components/LoggedInUser.tsx 📉 -5 B (-0.14%) 3.51 kB → 3.51 kB
src/components/reports/graphs/CashFlowGraph.tsx 📉 -5 B (-0.18%) 2.78 kB → 2.77 kB
src/components/budget/MonthCountSelector.tsx 📉 -5 B (-0.34%) 1.45 kB → 1.44 kB
src/style/themes/dark.ts 📉 -145 B (-1.30%) 10.87 kB → 10.73 kB
src/style/themes/development.ts 📉 -148 B (-1.41%) 10.27 kB → 10.12 kB
src/style/themes/light.ts 📉 -217 B (-1.83%) 11.6 kB → 11.38 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
static/js/main.js 1.12 MB → 1.12 MB (-555 B) -0.05%
static/js/narrow-components.chunk.js 43.07 kB → 43.06 kB (-10 B) -0.02%
static/js/wide-components.chunk.js 126.86 kB → 126.85 kB (-8 B) -0.01%
static/js/reports.chunk.js 29.96 kB → 29.95 kB (-5 B) -0.02%

Unchanged

Asset File Size % Changed
static/js/848.chunk.js 760.98 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/713.chunk.js 156.56 kB 0%
static/js/231.chunk.js 117.37 kB 0%
static/js/473.chunk.js 13 kB 0%
static/js/312.chunk.js 12.78 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.88 kB 0%
static/css/main.css 7.41 kB 0%
asset-manifest.json 2.07 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 903 B 0%

@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2023

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.22 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.23 MB 0%
xfo.xfo.kcab.worker.js 1014.46 kB 0%

@youngcw
Copy link
Member

youngcw commented Oct 21, 2023

@carkom This seems fine to me. If you fix the conflicts I will merge this in.

@carkom
Copy link
Contributor Author

carkom commented Oct 21, 2023

@carkom This seems fine to me. If you fix the conflicts I will merge this in.

@youngcw All set! Thanks. You mind having a look at 1789 as well? Similar PR.

@youngcw youngcw merged commit 25f4e2a into actualbudget:master Oct 21, 2023
17 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Oct 21, 2023
@carkom carkom deleted the colorConsolidation branch November 9, 2023 23:56
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
* page color updates

* notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants