Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Darkmode: fix theming on budget table #1795

Merged
merged 4 commits into from
Oct 16, 2023
Merged

Darkmode: fix theming on budget table #1795

merged 4 commits into from
Oct 16, 2023

Conversation

youngcw
Copy link
Member

@youngcw youngcw commented Oct 14, 2023 •
edited
Loading

Much of the budget table wasn't themed, but had hard coded colors. This moves over to the theme values. Dark theme I think needs edited to fix the group colors.

Existing
image

New:
image

@netlify
Copy link

netlify bot commented Oct 14, 2023 •
edited
Loading

✅ Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 4193313
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/652ae1d2c1d94b00081ea0f6
😎 Deploy Preview https://deploy-preview-1795.demo.actualbudget.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@youngcw
Copy link
Member Author

youngcw commented Oct 14, 2023

@carkom Here is some help

@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2023 •
edited
Loading

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 2.82 MB → 2.82 MB (+65 B) +0.00%
Changeset
File Δ Size
src/components/budget/ExpenseCategory.js 📈 +45 B (+1.70%) 2.59 kB → 2.63 kB
src/components/budget/BudgetTotals.js 📈 +14 B (+0.29%) 4.68 kB → 4.69 kB
src/components/budget/BudgetCategories.js 📈 +28 B (+0.26%) 10.37 kB → 10.39 kB
src/components/budget/BudgetTable.js 📈 +27 B (+0.25%) 10.53 kB → 10.56 kB
src/style/themes/dark.ts 📈 +5 B (+0.05%) 10.7 kB → 10.7 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/wide-components.chunk.js 126.79 kB → 126.86 kB (+65 B) +0.05%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/main.js 1.12 MB 0%
static/js/848.chunk.js 760.98 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/713.chunk.js 156.56 kB 0%
static/js/231.chunk.js 117.37 kB 0%
static/js/narrow-components.chunk.js 43.06 kB 0%
static/js/reports.chunk.js 29.92 kB 0%
static/js/473.chunk.js 13 kB 0%
static/js/389.chunk.js 12.77 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.88 kB 0%
static/css/main.css 7.41 kB 0%
asset-manifest.json 2.07 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 903 B 0%

@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2023 •
edited
Loading

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.22 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.23 MB 0%
xfo.xfo.kcab.worker.js 1014.46 kB 0%

@carkom
Copy link
Contributor

carkom commented Oct 14, 2023 •
edited
Loading

This looks pretty good. Thanks for your help. Just a couple nits below.

You'll also want to change altTableBackground to navy700 in order to match the light theme look.

@trafico-bot trafico-bot bot added ⚠️ Changes requested Pull Request needs changes before it can be reviewed again and removed 🔍 Ready for Review labels Oct 14, 2023
@trafico-bot trafico-bot bot added 🔍 Ready for Review and removed ⚠️ Changes requested Pull Request needs changes before it can be reviewed again labels Oct 14, 2023
carkom
carkom approved these changes Oct 15, 2023
View reviewed changes
Copy link
Contributor

@carkom carkom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joel-jeremy joel-jeremy merged commit b45615e into actualbudget:master Oct 16, 2023
17 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Oct 16, 2023
@youngcw youngcw deleted the darkMode_budgettable branch October 31, 2023 23:22
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
@youngcw
Darkmode: fix theming on budget table (actualbudget#1795)
259b008 
* fix darkmode for budget table

* note

* lint

* fix totals line, fix group colot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carkom carkom carkom approved these changes

@joel-jeremy joel-jeremy joel-jeremy approved these changes

Assignees
No one assigned
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@youngcw @carkom @joel-jeremy