Goals: Save full goal value and add an indicator of goal status #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 🔥 removing privacyMode feature flag (#1688) * 🎨 fix multiline label in schedules modal (#1687) * Update Visual Regression README File (#1689) * Fix typo in GoCardlessLink.js (#1684) happend -> happened * queried cleared balance for tooltip (#1678) * Dark Theme Reports/Settings (#1512) * 🐛 Mobile account transaction list: Fix sticky date section headers (#1698) * 👷 do not cancel github ci jobs on master branch (#1692) * Sidebar Account Fix (#1703) * Dark Theme Final (#1513) * Category autocomplete should only search selectable categories (#1681) * set colors based on a goal value * extra comment --------- Co-authored-by: Matiss Janis Aboltins <[email protected]> Co-authored-by: Crazypkr1099 <[email protected]> Co-authored-by: Ikko Eltociear Ashimine <[email protected]> Co-authored-by: Shaan Khosla <[email protected]> Co-authored-by: Neil <[email protected]> Co-authored-by: Trevor Farlow <[email protected]>
* cleanup * I think its working * lint
Goal progress bar
* [refactor] Migrate Schedules Table to typescript (#1691) * 🔧 removing unnecessary manual module resolution (#1707) * 🐛 (mobile) scrolling in lists with pull-to-refresh (#1706) * 💄 (mobile) updating apple home-screen icon (#1705) * Enhance Y-Axis Scaling on Net Worth Graph (#1709) * fix report budget, by adding in the goal coloring --------- Co-authored-by: Mohamed Muhsin <[email protected]> Co-authored-by: Matiss Janis Aboltins <[email protected]> Co-authored-by: Crazypkr1099 <[email protected]>
joel-jeremy
reviewed
Nov 6, 2023
packages/desktop-client/src/components/spreadsheet/CellValue.tsx
Outdated
Show resolved
Hide resolved
joel-jeremy
reviewed
Nov 6, 2023
packages/desktop-client/src/components/budget/BalanceWithCarryover.tsx
Outdated
Show resolved
Hide resolved
joel-jeremy
reviewed
Nov 6, 2023
joel-jeremy
reviewed
Nov 7, 2023
joel-jeremy
approved these changes
Nov 8, 2023
Co-authored-by: Joel Jeremy Marquez <[email protected]>
trafico-bot
bot
added
✨ Merged
youngcw
added a commit
to actualbudget/docs
that referenced
this pull request
Nov 10, 2023
matches [actual#1780](actualbudget/actual#1780)
2 tasks
FlorianLang06
pushed a commit
to FlorianLang06/actual
that referenced
this pull request
Mar 7, 2024
…albudget#1780) * first pass at progress bar * db migration / enter goal in db * add getGoal function * stabilize * whoops * TS * reset goal in db if no template found * reconfirm * release note * typo * rename migration * to ms * move priority logic, consistent variable names, * fixup * clear goal if template removed * Visual goals (#40) * 🔥 removing privacyMode feature flag (actualbudget#1688) * 🎨 fix multiline label in schedules modal (actualbudget#1687) * Update Visual Regression README File (actualbudget#1689) * Fix typo in GoCardlessLink.js (actualbudget#1684) happend -> happened * queried cleared balance for tooltip (actualbudget#1678) * Dark Theme Reports/Settings (actualbudget#1512) * 🐛 Mobile account transaction list: Fix sticky date section headers (actualbudget#1698) * 👷 do not cancel github ci jobs on master branch (actualbudget#1692) * Sidebar Account Fix (actualbudget#1703) * Dark Theme Final (actualbudget#1513) * Category autocomplete should only search selectable categories (actualbudget#1681) * set colors based on a goal value * extra comment --------- Co-authored-by: Matiss Janis Aboltins <[email protected]> Co-authored-by: Crazypkr1099 <[email protected]> Co-authored-by: Ikko Eltociear Ashimine <[email protected]> Co-authored-by: Shaan Khosla <[email protected]> Co-authored-by: Neil <[email protected]> Co-authored-by: Trevor Farlow <[email protected]> * update release note * lint * use null as cleared state * show goal status via colors (actualbudget#41) * cleanup * I think its working * lint * fix report budget, by adding in the goal coloring * fix the error by adding colors to the report side (actualbudget#42) * [refactor] Migrate Schedules Table to typescript (actualbudget#1691) * 🔧 removing unnecessary manual module resolution (actualbudget#1707) * 🐛 (mobile) scrolling in lists with pull-to-refresh (actualbudget#1706) * 💄 (mobile) updating apple home-screen icon (actualbudget#1705) * Enhance Y-Axis Scaling on Net Worth Graph (actualbudget#1709) * fix report budget, by adding in the goal coloring --------- Co-authored-by: Mohamed Muhsin <[email protected]> Co-authored-by: Matiss Janis Aboltins <[email protected]> Co-authored-by: Crazypkr1099 <[email protected]> * report budget database updates * Goal progress bar (actualbudget#1734) * first pass at progress bar * db migration / enter goal in db * add getGoal function * stabilize * whoops * TS * reset goal in db if no template found * reconfirm * release note * typo * rename migration * to ms * move priority logic, consistent variable names, * fixup * clear goal if template removed * Visual goals (#40) * 🔥 removing privacyMode feature flag (actualbudget#1688) * 🎨 fix multiline label in schedules modal (actualbudget#1687) * Update Visual Regression README File (actualbudget#1689) * Fix typo in GoCardlessLink.js (actualbudget#1684) happend -> happened * queried cleared balance for tooltip (actualbudget#1678) * Dark Theme Reports/Settings (actualbudget#1512) * 🐛 Mobile account transaction list: Fix sticky date section headers (actualbudget#1698) * 👷 do not cancel github ci jobs on master branch (actualbudget#1692) * Sidebar Account Fix (actualbudget#1703) * Dark Theme Final (actualbudget#1513) * Category autocomplete should only search selectable categories (actualbudget#1681) * set colors based on a goal value * extra comment --------- Co-authored-by: Matiss Janis Aboltins <[email protected]> Co-authored-by: Crazypkr1099 <[email protected]> Co-authored-by: Ikko Eltociear Ashimine <[email protected]> Co-authored-by: Shaan Khosla <[email protected]> Co-authored-by: Neil <[email protected]> Co-authored-by: Trevor Farlow <[email protected]> * update release note * lint * use null as cleared state * show goal status via colors (actualbudget#41) * cleanup * I think its working * lint * fix the error by adding colors to the report side (actualbudget#42) * [refactor] Migrate Schedules Table to typescript (actualbudget#1691) * 🔧 removing unnecessary manual module resolution (actualbudget#1707) * 🐛 (mobile) scrolling in lists with pull-to-refresh (actualbudget#1706) * 💄 (mobile) updating apple home-screen icon (actualbudget#1705) * Enhance Y-Axis Scaling on Net Worth Graph (actualbudget#1709) * fix report budget, by adding in the goal coloring --------- Co-authored-by: Mohamed Muhsin <[email protected]> Co-authored-by: Matiss Janis Aboltins <[email protected]> Co-authored-by: Crazypkr1099 <[email protected]> * report budget database updates * Fix schedule searchbar (actualbudget#1729) --------- Co-authored-by: youngcw <[email protected]> Co-authored-by: Matiss Janis Aboltins <[email protected]> Co-authored-by: Crazypkr1099 <[email protected]> Co-authored-by: Ikko Eltociear Ashimine <[email protected]> Co-authored-by: Shaan Khosla <[email protected]> Co-authored-by: Neil <[email protected]> Co-authored-by: Trevor Farlow <[email protected]> Co-authored-by: Mohamed Muhsin <[email protected]> * working dynamic colors. Need to figure out what changes are actually needed * cleanup * more cleanup * lint * reset the goal when applying a single template * make getCategory function * remove some unneeded changes * actually remove the changes, not just comment * cleanup some unneeded code that was causing some bugs. Works for me, but should be vetted more * lint * add json definitions to database * use template feature flag to enable colors * some fixes * don't set goals for remainders, remove unneeded change * lint * release note * lint again * fix mobile crash * undo changes in CellValue.tsx * lint * use getStyle * move status calc to helper * lint * recommendations * suggestion Co-authored-by: Joel Jeremy Marquez <[email protected]> --------- Co-authored-by: shall0pass <[email protected]> Co-authored-by: Matiss Janis Aboltins <[email protected]> Co-authored-by: Crazypkr1099 <[email protected]> Co-authored-by: Ikko Eltociear Ashimine <[email protected]> Co-authored-by: Shaan Khosla <[email protected]> Co-authored-by: Neil <[email protected]> Co-authored-by: Trevor Farlow <[email protected]> Co-authored-by: Mohamed Muhsin <[email protected]> Co-authored-by: Joel Jeremy Marquez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step in a more capable goal template system. This adds a db column for saving the goal values, then uses that db value to color the category balance based on if the goal is met or not.
The respective handlers for db changes were modified so the budget cache updates as needed, and is setup upon a cache reset.
We also added in a db entry to save the template json so that once a gui is made to create the templates the db is already ready. Writing/reading from that field has been added so that the transition away from the notes will be smoother.
For testing:
Use a test file or an export of your budget to not cause db migration issues.
Existing Behavior/Templates Disabled
New Behavior
