Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync on ctrl+s #1770

Merged
merged 7 commits into from
Oct 10, 2023
Merged

Sync on ctrl+s #1770

merged 7 commits into from
Oct 10, 2023

Conversation

Compositr
Copy link
Contributor

Addresses [Bug]: ctrl+s should sync #1685

Adds a KeyHandlers to SyncButton to capture ctrl+s

* addresses [Bug]: ctrl+s should sync #1685
@netlify
Copy link

netlify bot commented Oct 8, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 296d59a
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/6524e36be0c1ac00081965d5
😎 Deploy Preview https://deploy-preview-1770.demo.actualbudget.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 2.48 MB → 2.48 MB (+101 B) +0.00%
Changeset
File Δ Size
src/components/Titlebar.tsx 📈 +535 B (+3.76%) 13.89 kB → 14.42 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/main.js 1.12 MB → 1.12 MB (+101 B) +0.01%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/678.chunk.js 420.74 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/713.chunk.js 156.56 kB 0%
static/js/wide-components.chunk.js 126.84 kB 0%
static/js/231.chunk.js 117.37 kB 0%
static/js/narrow-components.chunk.js 34.74 kB 0%
static/js/reports.chunk.js 29.23 kB 0%
static/js/473.chunk.js 13 kB 0%
static/js/389.chunk.js 12.77 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.88 kB 0%
static/css/main.css 7.41 kB 0%
asset-manifest.json 2.07 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 903 B 0%

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.22 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.23 MB 0%
xfo.xfo.kcab.worker.js 1014.46 kB 0%

Copy link
Member

@MatissJanis MatissJanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would also make sense to add cmd+s support for this for mac users. WDYT?

packages/desktop-client/src/components/Titlebar.tsx Outdated Show resolved Hide resolved
@shaankhosla
Copy link
Contributor

shaankhosla commented Oct 9, 2023

I think it would also make sense to add cmd+s support for this for mac users. WDYT?

I think that's necessary, on my mac I don't see the Sync button and cmd+s doesn't work.
image

Co-authored-by: MatissJanis

Co-authored-by: Matiss Janis Aboltins <[email protected]>
@Compositr
Copy link
Contributor Author

I think it would also make sense to add cmd+s support for this for mac users. WDYT?

I think that's necessary, on my mac I don't see the Sync button and cmd+s doesn't work. image

I think the sync button only appears when you're using a server (the demo file has no server) which is expected behaviour afaik.

I'll look into Mac command key support though although I don't have a Mac so I'm not quite sure how to emulate the command key.

* Keyhanders requires us to return void
'ctrl+s': () => {
sync();
},
'ctrl+s': sync,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out KeyHandler's props doesn't like this, so I've reverted this in 8144661

Compositr and others added 2 commits October 10, 2023 16:37
@MatissJanis MatissJanis merged commit bdf5c45 into actualbudget:master Oct 10, 2023
17 checks passed
@trafico-bot trafico-bot bot added ✅ Approved ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review ✨ Merged Pull Request has been merged successfully labels Oct 10, 2023
@shaankhosla shaankhosla mentioned this pull request Oct 12, 2023
1 task
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants