-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swipe up mobile navbar #1758
Swipe up mobile navbar #1758
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
94c39be
to
0d72c72
Compare
0d72c72
to
e8dab6d
Compare
9487a04
to
48ac227
Compare
329af8c
to
1a354c9
Compare
I really like this interaction! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has my 👍.
4f4f53d
to
62d0a4c
Compare
Some tests are failing due to the settings menu now hidden and can't be clicked by playwright. I'm trying to figure out how to do a swipe up on the e2e tests so that the settings and other button can become clickable but no luck so far. Any help or ideas would be appreciated. |
@MatissJanis Any suggestions on how to implement swipe up in tests? I tried some solutions I found online but it doesn't drag the nav tabs up. |
Would this work? https://playwright.dev/docs/input#drag-and-drop On a different note: what if we had the "+" icon in the middle? Maybe it's just me, but that's where budgeting apps usually have it. Not a blocker though. |
Unfortunately, I have tried that and doesn't seem to work so I'm stuck :( Yeah, putting the + in the middle makes sense. I'll update it tomorrow. |
Fixed the e2e tests for you: fe3a4e1 Though you'll want to solve the lint issue and also merge the latest |
fe3a4e1
to
7eb1867
Compare
Thank you @MatissJanis! Rebased from master and tests are now passing. |
* Swipe up mobile navbar to reveal more menus * Release notes * Revert navbar button height to 70 * Reduce debounce value * More tabs coming soon * VRT update * VRT update * Fix: e2e tests * Smoother mobile navtabs --------- Co-authored-by: Matiss Janis Aboltins <[email protected]>
Swipe up mobile navbar to reveal more menus.