Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swipe up mobile navbar #1758

Merged
merged 9 commits into from
Nov 13, 2023

Conversation

joel-jeremy
Copy link
Contributor

@joel-jeremy joel-jeremy commented Oct 2, 2023

Swipe up mobile navbar to reveal more menus.

@trafico-bot trafico-bot bot added the 🚧 WIP label Oct 2, 2023
@netlify
Copy link

netlify bot commented Oct 2, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 7eb1867
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/65529a6da4173300085a84fd
😎 Deploy Preview https://deploy-preview-1758.demo.actualbudget.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 2.85 MB → 2.88 MB (+31.74 kB) +1.09%
Changeset
File Δ Size
../../node_modules/@use-gesture/core/dist/actions-fe213e88.esm.js 🆕 +45.51 kB 0 B → 45.51 kB
../../node_modules/@use-gesture/core/dist/use-gesture-core.esm.js 🆕 +10.99 kB 0 B → 10.99 kB
../../node_modules/@use-gesture/react/dist/use-gesture-react.esm.js 🆕 +2.23 kB 0 B → 2.23 kB
../../node_modules/@use-gesture/core/dist/maths-0ab39ae9.esm.js 🆕 +1.24 kB 0 B → 1.24 kB
src/components/mobile/MobileNavTabs.tsx 📈 +3.65 kB (+137.21%) 2.66 kB → 6.31 kB
package.json 📈 +31 B (+1.41%) 2.15 kB → 2.18 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/main.js 1.12 MB → 1.15 MB (+31.74 kB) +2.77%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/460.chunk.js 774.35 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/444.chunk.js 156.11 kB 0%
static/js/wide-components.chunk.js 127.08 kB 0%
static/js/231.chunk.js 117.37 kB 0%
static/js/narrow-components.chunk.js 52.15 kB 0%
static/js/reports.chunk.js 35.97 kB 0%
static/js/473.chunk.js 13 kB 0%
static/js/312.chunk.js 12.93 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.88 kB 0%
static/css/main.css 7.41 kB 0%
asset-manifest.json 2.07 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 903 B 0%

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.22 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.23 MB 0%
xfo.xfo.kcab.worker.js 1014.46 kB 0%

@joel-jeremy joel-jeremy force-pushed the swipe-up-mobile-navbar branch 2 times, most recently from 94c39be to 0d72c72 Compare October 2, 2023 22:31
@joel-jeremy joel-jeremy force-pushed the swipe-up-mobile-navbar branch from 0d72c72 to e8dab6d Compare October 11, 2023 16:24
@joel-jeremy joel-jeremy force-pushed the swipe-up-mobile-navbar branch from 9487a04 to 48ac227 Compare October 23, 2023 02:07
@joel-jeremy joel-jeremy changed the title [WIP] Swipe up mobile navbar Swipe up mobile navbar Oct 23, 2023
@joel-jeremy joel-jeremy force-pushed the swipe-up-mobile-navbar branch from 329af8c to 1a354c9 Compare October 23, 2023 02:22
@shall0pass
Copy link
Contributor

I really like this interaction!

Copy link
Contributor

@shall0pass shall0pass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has my 👍.

@joel-jeremy
Copy link
Contributor Author

joel-jeremy commented Nov 9, 2023

Some tests are failing due to the settings menu now hidden and can't be clicked by playwright. I'm trying to figure out how to do a swipe up on the e2e tests so that the settings and other button can become clickable but no luck so far. Any help or ideas would be appreciated.

@joel-jeremy
Copy link
Contributor Author

@MatissJanis Any suggestions on how to implement swipe up in tests? I tried some solutions I found online but it doesn't drag the nav tabs up.

@MatissJanis
Copy link
Member

Would this work? https://playwright.dev/docs/input#drag-and-drop

On a different note: what if we had the "+" icon in the middle? Maybe it's just me, but that's where budgeting apps usually have it. Not a blocker though.

@joel-jeremy
Copy link
Contributor Author

Unfortunately, I have tried that and doesn't seem to work so I'm stuck :(

Yeah, putting the + in the middle makes sense. I'll update it tomorrow.

@MatissJanis
Copy link
Member

Fixed the e2e tests for you: fe3a4e1

Though you'll want to solve the lint issue and also merge the latest master branch in here before merging.

@joel-jeremy joel-jeremy force-pushed the swipe-up-mobile-navbar branch from fe3a4e1 to 7eb1867 Compare November 13, 2023 21:51
@joel-jeremy
Copy link
Contributor Author

Thank you @MatissJanis! Rebased from master and tests are now passing.

@joel-jeremy joel-jeremy merged commit a399558 into actualbudget:master Nov 13, 2023
16 of 19 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review labels Nov 13, 2023
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
* Swipe up mobile navbar to reveal more menus

* Release notes

* Revert navbar button height to 70

* Reduce debounce value

* More tabs coming soon

* VRT update

* VRT update

* Fix: e2e tests

* Smoother mobile navtabs

---------

Co-authored-by: Matiss Janis Aboltins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants