[Bug] End of month cleanup error #1750
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
|
Could you assume that a nulll value is the same as carryover being false? Then not need to write to the db an extra time? |
|
I think you're right. If carryover is null, it will always be 0. I've updated the check to simply set carryover to 0 if it is null before moving on to the if statement. |
trafico-bot
bot
added
✨ Merged
* check for null carryover * release note * simplify logic
This feels like a hack. There's probably a more elegant way to handle this condition. The report is correct in that the carryover isn't created initially. To replicate the error:
The master branch will show the error that is reported. What I have done here is check for the null value. If a null value is found, set the budget cell to it's current value. By doing this, the database tables get updated and carryover will no longer be reported as null.
#1748