[Bugfix]: Goals - Fixed an overbudgeting condition

[shall0pass]

If a category had two templates, it was possible to overbudget in a category if the priority level was lower. I've attached a test budget.

To replicate, set the Food budget to zero and then apply the templates. demo.actualbudget.org and this PR will provide different calculated fills.

PR_test-budget.zip

[netlify]

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	0c7da03
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/6512e9431cdcfb0008ff8e3f
😎 Deploy Preview	https://deploy-preview-1738.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
16	2.48 MB → 2.48 MB (-15 B)	-0.00%

Changeset

File	Δ	Size
src/components/accounts/Header.js	📉 -45 B (-0.23%)	18.75 kB → 18.71 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset	File Size	% Changed
static/js/wide-components.chunk.js	126.9 kB → 126.88 kB (-15 B)	-0.01%

Unchanged

Asset	File Size	% Changed
static/js/main.js	1.12 MB	0%
static/js/678.chunk.js	420.74 kB	0%
static/media/Inter-italic.var.woff2	239.29 kB	0%
static/media/Inter-roman.var.woff2	221.86 kB	0%
static/js/713.chunk.js	156.56 kB	0%
static/js/231.chunk.js	117.37 kB	0%
static/js/narrow-components.chunk.js	35.15 kB	0%
static/js/reports.chunk.js	29.23 kB	0%
static/js/473.chunk.js	13 kB	0%
static/js/389.chunk.js	12.76 kB	0%
static/js/resize-observer-polyfill.chunk.js	8.88 kB	0%
static/css/main.css	7.41 kB	0%
asset-manifest.json	2.07 kB	0%
index.html	1.66 kB	0%
static/media/browser-server.js	903 B	0%

[github-actions]

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
2	2.22 MB → 2.22 MB (+22 B)	+0.00%

Changeset

File	Δ	Size
packages/loot-core/src/server/budget/goaltemplates.ts	📈 +178 B (+0.54%)	31.96 kB → 32.13 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
kcab.worker.js	1.23 MB → 1.23 MB (+22 B)	+0.00%

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
xfo.xfo.kcab.worker.js	1014.46 kB	0%

[youngcw]

looks to be passing both your sample and my test. I think this made it passed me because I didn't have a double priority test in my test budget.

[shall0pass]

I think this is a candidate to merge during the current merge freeze. Agreed?

[youngcw]

I think this is a candidate to merge during the current merge freeze. Agreed?

I think this is a good candidate. Isn't this bug only in the edge build?

[shall0pass]

I think this is a candidate to merge during the current merge freeze. Agreed?

I think this is a good candidate. Isn't this bug only in the edge build?

I spotted it on my stable budget.

[youngcw]

I spotted it on my stable budget.

Oh, I must have been thinking of some of the stuff in the goalProgress changes

[youngcw]

But a bugfix is still a good thing to merge I would think