Mobile category and group functionalities #1737
Conversation
joel-jeremy
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller
Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
joel-jeremy
changed the title
|
The income group is now a dimmed color. Im guessing that wasn't intentional. Everything else seems good |
|
Cool! I found it a little hard to find a place to touch to close the menu if a category menu was opened. If I touched up, a new menu was opened and if touched to the right the budget cell would be edited. I finally found a spot near the top of the screen that worked repeatedly, but it wasn't really obvious what I needed to do to close it. *I just discovered that scrolling will close it. |
|
Thank you for the feedback! The import group styling should now be fixed. I also added a close button on the category tooltip to make it easier to close and cancel the category rename - hopefully that will make the UX better. :) |
|
This may be best for another PR, but if you wanted to be a hero, a button for templates in the new menus would be great. I have no issues as it stands now UI/UX wise. |
|
Yeah, I'm planning to that in separate PR :) |
packages/desktop-client/src/components/budget/MobileBudgetTable.js
Outdated
Show resolved
Hide resolved
|
Looks great @joel-jeremy ! Love how you fix the long names of the category to do the ... Thanks! |
joel-jeremy
force-pushed
the
mobile-category-and-group-menu
branch
from
a4d8407 to
e5dba78
Compare
|
@MatissJanis I have address the PR comments from #1662 here. |
joel-jeremy
force-pushed
the
mobile-category-and-group-menu
branch
from
426c2e6 to
909945c
Compare
There was a problem hiding this comment.
Some bugs:
- when editing category name: change the name and then close the tooltip with "x" without saving; then open it back up - the previous state will be visible; it would be more natural to reset it back to the original if "x" is clicked without saving
- delete group is not working
Overall looks very good! Thanks for adding this!
joel-jeremy
force-pushed
the
mobile-category-and-group-menu
branch
from
909945c to
e2f867d
Compare
trafico-bot
bot
added
✨ Merged
* More mobile functionalities * Cleanup * Remove close button on mobile budget summary modal * Release notes * Close mobile inputs on enter * Fix mobile budget row header color * Fix income group hidden * Add validation + close button on category tooltip * Add mobile budget visual cues * More mobile visual cues * Error message fix * Update blank category name behavior * Cleanup * Cleanup * Fix mobile group deletion and category tooltip behavior * Zero sign for AmountInput * VRT snapshot updates * Handle null values in must-category-transfer
This is made on top of #1662 so that needs to be merged first before this.
Changes include (all mobile):