Consolidate Notice Colors #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
carkom
commented
Sep 22, 2023
| @@ -159,7 +159,7 @@ export function Balances({ | |||
| value < 0 | |||
| ? theme.errorText | |||
| : value > 0 | |||
| ? theme.noticeText | |||
| ? theme.noticeTextLight | |||
| : theme.pageTextSubdued, | |||
carkom
commented
Sep 22, 2023
| @@ -100,7 +100,7 @@ function AccountCard({ account, updated, getBalanceQuery, onSelect }) { | |||
| {account.bankId && ( | |||
| <View | |||
| style={{ | |||
| backgroundColor: theme.noticeText, | |||
| backgroundColor: theme.noticeBackgroundDark, | |||
| marginLeft: '-23px', | |||
carkom
commented
Sep 22, 2023
| @@ -45,7 +45,7 @@ export function ReconcilingMessage({ | |||
| {targetDiff === 0 ? ( | |||
| <View | |||
| style={{ | |||
| color: theme.noticeText, | |||
| color: theme.noticeTextLight, | |||
| flex: 1, | |||
carkom
commented
Sep 22, 2023
| @@ -93,7 +93,7 @@ function CategoryList({ | |||
| alignItems: 'center', | |||
| fontSize: 11, | |||
| fontWeight: 500, | |||
| color: theme.noticeAccent, | |||
| color: theme.noticeTextMenu, | |||
| padding: '6px 8px', | |||
carkom
commented
Sep 22, 2023
| @@ -99,7 +99,7 @@ function PayeeList({ | |||
| <View | |||
| style={{ | |||
| display: 'block', | |||
| color: theme.noticeAccent, | |||
| color: theme.noticeTextMenu, | |||
| borderRadius: 4, | |||
carkom
commented
Sep 22, 2023
| @@ -99,7 +99,7 @@ function IncomeProgress({ current, target }: IncomeProgressProps) { | |||
| return ( | |||
| <PieProgress | |||
| progress={frac} | |||
| color={over ? theme.errorText : theme.noticeText} | |||
| color={over ? theme.errorText : theme.noticeTextLight} | |||
| backgroundColor={over ? theme.errorBackground : theme.pageBackground} | |||
carkom
commented
Sep 22, 2023
| @@ -132,7 +132,7 @@ function ExpenseProgress({ current, target }: ExpenseProgressProps) { | |||
| return ( | |||
| <PieProgress | |||
| progress={frac} | |||
| color={over ? theme.errorText : theme.noticeText} | |||
| color={over ? theme.errorText : theme.noticeTextLight} | |||
| backgroundColor={over ? theme.errorBackground : theme.pageBackground} | |||
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller
Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
carkom
commented
Sep 22, 2023
| @@ -73,7 +73,7 @@ export default function ChangePassword() { | |||
| <Text | |||
| style={{ | |||
| marginTop: 20, | |||
| color: theme.noticeText, | |||
| color: theme.noticeTextLight, | |||
| borderRadius: 4, | |||
carkom
commented
Sep 22, 2023
| @@ -10,7 +10,7 @@ function Change({ amount }) { | |||
| <Block | |||
| style={{ | |||
| ...styles.smallText, | |||
| color: amount < 0 ? theme.errorText : theme.noticeText, | |||
| color: amount < 0 ? theme.errorText : theme.noticeTextLight, | |||
| }} | |||
carkom
commented
Sep 22, 2023
| @@ -168,7 +168,7 @@ export function ScheduleAmountCell({ | |||
| <Text | |||
| style={{ | |||
| flex: 1, | |||
| color: num > 0 ? theme.noticeText : theme.tableText, | |||
| color: num > 0 ? theme.noticeTextLight : theme.tableText, | |||
| whiteSpace: 'nowrap', | |||
carkom
commented
Sep 22, 2023
| @@ -26,7 +26,7 @@ export default function EncryptionSettings() { | |||
| primaryAction={<Button onClick={onChangeKey}>Generate new key</Button>} | |||
| > | |||
| <Text> | |||
| <Text style={{ color: theme.noticeText, fontWeight: 600 }}> | |||
| <Text style={{ color: theme.noticeTextLight, fontWeight: 600 }}> | |||
| End-to-end Encryption is turned on. | |||
carkom
commented
Sep 22, 2023
| @@ -1001,7 +1001,9 @@ class Transaction extends PureComponent { | |||
| style={{ | |||
| width: 11, | |||
| height: 11, | |||
| color: cleared ? theme.noticeText : theme.altButtonBareText, | |||
carkom
commented
Sep 22, 2023
| @@ -416,7 +416,7 @@ function StatusCell({ | |||
|
|
|||
| let statusColor = | |||
| status === 'cleared' | |||
| ? theme.noticeText | |||
MatissJanis
approved these changes
Sep 23, 2023
|
No, not just POC. It's more like the first of many 🤣 |
trafico-bot
bot
added
✨ Merged
FlorianLang06
pushed a commit
to FlorianLang06/actual
that referenced
this pull request
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof of concept for consolidating colors to make the apps color scheme more consistent. We are using 5 different shades of dark green for text fields. Looking to slim this down to 3 and consolidate background colors a bit as well and clean up the naming standards.
It should also help to make the palette more compact allowing for easier creation of more themes.
There are places where the color hasn't actually changed but the name of the color has. I'll try to point out the bits where the color has changed by one shade so you don't have to review all the ones where color is the same but name is different.