changed default months to 5 in cash flow report #1723
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller
Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
|
This is a before and after 
|
|
I would call this an enhancement not a bug. But yeah it looks way better as 5 months. |
| @@ -33,7 +33,7 @@ function CashFlow() { | |||
|
|
|||
| const [allMonths, setAllMonths] = useState(null); | |||
| const [start, setStart] = useState( | |||
| monthUtils.subMonths(monthUtils.currentMonth(), 30), | |||
| monthUtils.subMonths(monthUtils.currentMonth(), 5), | |||
There was a problem hiding this comment.
👏 praise: this is great, but would be even better if we would store this in local storage. And then re-use between all the reports.
(not necessary to change unless you want to)
There was a problem hiding this comment.
That might be a bit out of reach of my ability so it might take a bit longer for me to do. I'm happy for this to be merged in if you approve and I can try to do that in another PR.
Co-authored-by: Matiss Janis Aboltins <[email protected]>
trafico-bot
bot
added
✨ Merged
This is a very minor change. It bothered me that the after opening the Cash Flow report, the default number of months is so large (30 months shown). I've changed this to 5 months which is what the Net Worth graph does.
I also thought about changing it to all months until the date of the first transaction but decided against this.