Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Category List: Category Color Addition #1715

Closed
wants to merge 64 commits into from
Closed

[WIP] Category List: Category Color Addition #1715

wants to merge 64 commits into from

Conversation

Crazypkr1099
Copy link
Contributor

No description provided.

Crazypkr1099 and others added 30 commits September 3, 2023 20:03
Change to React's CSSProperties
Prettified certain lines
temporarily fix for "projected savings" label text to fit flex box properly
Removed failed attempt at flex-basis
This reverts commit 6e0469d.
@netlify
Copy link

netlify bot commented Sep 20, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit ef6a1cf
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/650c84038bcc620008c700be
😎 Deploy Preview https://deploy-preview-1715.demo.actualbudget.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2023

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 2.48 MB → 2.48 MB (+677 B) +0.03%
Changeset
File Δ Size
src/components/reports/graphColors.js 🆕 +551 B 0 B → 551 B
src/components/reports/CategorySelector.tsx 📈 +1.03 kB (+14.42%) 7.15 kB → 8.18 kB
src/components/reports/graphs/CategorySpendingGraph.tsx 📈 +50 B (+1.76%) 2.77 kB → 2.82 kB
src/components/PrivacyFilter.tsx 📉 -389 B (-9.79%) 3.88 kB → 3.5 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/reports.chunk.js 29.23 kB → 29.67 kB (+453 B) +1.51%
static/js/main.js 1.11 MB → 1.11 MB (+224 B) +0.02%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/678.chunk.js 420.74 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/713.chunk.js 156.56 kB 0%
static/js/wide-components.chunk.js 126.98 kB 0%
static/js/231.chunk.js 117.37 kB 0%
static/js/narrow-components.chunk.js 35.15 kB 0%
static/js/473.chunk.js 13 kB 0%
static/js/389.chunk.js 12.76 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.88 kB 0%
static/css/main.css 7.41 kB 0%
asset-manifest.json 2.07 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 903 B 0%

@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2023

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.22 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.23 MB 0%
xfo.xfo.kcab.worker.js 1014.46 kB 0%

@MatissJanis
Copy link
Member

👋 This is a pretty cool addition. Any plans to pick it up again to resolve the CI jobs? I could give it a review after CI passes.

@Crazypkr1099
Copy link
Contributor Author

Hi @MatissJanis I stopped after I figured we are going to change libraries. I'll pick this up once that is done :)

@MatissJanis MatissJanis changed the title Category List: Category Color Addition [WIP] Category List: Category Color Addition Oct 10, 2023
@Crazypkr1099 Crazypkr1099 deleted the categoryColor branch October 11, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants