Hide hidden groups and categories in spending report category selector

[kyrias]

In the future we should have a way to optionally toggle these to be visible like we do on the budget page, but that requires figuring out a decent UI for this.

[netlify]

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	9087151
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/650378ad5e219f000899afe7
😎 Deploy Preview	https://deploy-preview-1696.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
16	2.47 MB → 2.47 MB (+8 B)	+0.00%

Changeset

File	Δ	Size
src/components/reports/CategorySelector.tsx	📈 +121 B (+1.65%)	7.15 kB → 7.27 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
static/js/reports.chunk.js	28.73 kB → 28.74 kB (+8 B)	+0.03%

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/main.js	1.11 MB	0%
static/js/678.chunk.js	420.74 kB	0%
static/media/Inter-italic.var.woff2	239.29 kB	0%
static/media/Inter-roman.var.woff2	221.86 kB	0%
static/js/713.chunk.js	156.56 kB	0%
static/js/wide-components.chunk.js	126.09 kB	0%
static/js/231.chunk.js	117.37 kB	0%
static/js/narrow-components.chunk.js	34.17 kB	0%
static/js/473.chunk.js	13 kB	0%
static/js/389.chunk.js	12.76 kB	0%
static/js/resize-observer-polyfill.chunk.js	8.88 kB	0%
static/css/main.css	7.41 kB	0%
asset-manifest.json	2.07 kB	0%
index.html	1.66 kB	0%
static/media/browser-server.js	903 B	0%

[github-actions]

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
2	2.22 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.23 MB	0%
xfo.xfo.kcab.worker.js	1014.46 kB	0%

[kyrias]

Hmm, I'm a bit confused, why are hidden and is_income integers rather than booleans? I think that means that we're lying in other places where we declare those fields as boolean.

[MatissJanis]

Small bug: when the group has only hidden categories - it cannot be toggle-able.

Demo budget:
2023-09-16-_test-budget.zip

[MatissJanis]

Also: I don't think we should remove the hidden categories from the category selector. Ideally we would have a way to toggle the visibility of them (as in budget page), but until we have this functionality - I would argue it's better to show them and allow people to toggle them off than it is to explicitly remove them without the option of adding them back in.

[kyrias]

Small bug: when the group has only hidden categories - it cannot be toggle-able.

That's not a new bug, but I was meaning to hide hidden groups as well.

but until we have this functionality - I would argue it's better to show them and allow people to toggle them off than it is to explicitly remove them without the option of adding them back in.

I personally don't think that makes sense. If someone explicitly marks something as hidden it should be hidden until you mark it otherwise, and until a toggle is implemented they can just mark the category as not hidden if they want to see it. But up to you.

[MatissJanis]

A relatively quick UI fix here might be:

• show the hidden categories by default
• use a different color for them (light gray?)
• by default: have them in the "unchecked" state

That wouldn't require any specific toggle element, but would be a short-term solution to the problem.