Autocomplete components on mobile #1673
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
| @@ -151,7 +151,7 @@ class AmountInput extends PureComponent { | |||
| autoCapitalize="none" | |||
| onChange={e => this.onChangeText(e.target.value)} | |||
| onBlur={this.onBlur} | |||
| onKeyPress={this.onKeyPress} | |||
| onKeyUp={this.onKeyUp} | |||
There was a problem hiding this comment.
Updated since onKeyPress is now deprecated.
joel-jeremy
changed the title
joel-jeremy
force-pushed
the
autocomplete-components-on-mobile
branch
from
7f09f61 to
58cfdf5
Compare
|
The biggest benefit of the old autocomplete was that it opened up full-screen. Whereas the new one has a very small scroll window. For mobile devices the full-screen view IMO is much better. WDYT @trevdor ? 
|
|
I agree. The mobile autocomplete should really be a “sheet” in the native sense of the word, not a simple drop down like on desktop. I suspect we’d better develop the mobile one further to be even more different from desktop rather than unify them. Apologies for not thinking of this sooner. |
I suppose this might be achievable in a unified component. But it could also prove too complicated trying to wrangle two very different designs in one. (and fwiw, in my opinion the existing mobile autocomplete is pretty much the goal—already emulates a sheet, though maybe with some larger touch targets eventually. |
|
Sounds good! Just tried experimenting with it. Closing this PR. :) |
Reuse desktop's autocomplete components in mobile.