Webpack + SWC Loader #1650
Merged
Webpack + SWC Loader #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset (largest 100 files by percent change)
View detailed bundle breakdownAdded
Removed
Bigger
Smaller
Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset (largest 100 files by percent change)
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged No assets were unchanged |
-75.43% reduction in build timeCurrent build time:
|
|
Really cool. Let me know when you want me to review this. |
Closed
loot-core tests: (-44% in execution time)ts-jest execution time
SWC execution time
crdt tests (-88.2% in execution time)ts-jest execution time
SWC execution time
For some reason crdt tests fail in local but succeeds in CI. I haven't looked into why that is. |
|
@MatissJanis @shall0pass @trevdor This is ready for review :) There seem to be an increase in bundle size due to the switch but build and test execution time has dramatically improved. Aside: It looks like github action is not caching packages? |
|
Just pushed a small patch for electron app I found while testing this PR. Hope you don't mind. |
MatissJanis
reviewed
Sep 5, 2023
| @@ -40,7 +43,6 @@ | |||
| "memoize-one": "^6.0.0", | |||
| "pikaday": "1.8.0", | |||
| "react": "18.2.0", | |||
| "react-app-rewired": "^2.2.1", | |||
There was a problem hiding this comment.
💬 suggestion: react-scripts can also be removed IMO
There was a problem hiding this comment.
Craco still uses react-scripts under the hood I believe: https://craco.js.org/docs/getting-started/
.github/actions/setup/action.yml
Outdated
| with: | ||
| path: '**/node_modules' | ||
| key: yarn-v1-${{ runner.os }}-${{ hashFiles('.nvmrc') }}-${{ hashFiles('**/yarn.lock') }} | ||
| cache: yarn |
There was a problem hiding this comment.
💬 suggestion: The default cache mechanism does not take into account .nvmrc file. That's why we created a custom cache key here.
With the proposed change the cache will not be invalidated when we bump the node version in .nvmrc
There was a problem hiding this comment.
Oh I see, I'll revert this change
Ok, this broke VRT.. apologies. I reverted my change. Will patch it in a separate PR. |
|
🤦 it was not my changes.. the VRT in Updating the branch should solve the issue |
This reverts commit 787af19.
joel-jeremy
force-pushed
the
swc-loader
branch
from
4003f49 to
f8d0075
Compare
|
I have rebased the branch. Feel free to commit your electron fix :) |
MatissJanis
approved these changes
Sep 5, 2023
trafico-bot
bot
added
✨ Merged
FlorianLang06
pushed a commit
to FlorianLang06/actual
that referenced
this pull request
Mar 7, 2024
* desktopc-client swc-loader * More swc * Jest swc + upgrades * Revert @swc/jest usage for now * SWC minify * Remove setupFilesAfterEnv in package.json as per warning message in CI * Release notes * Minify on CI * swc helpers in loot-core * @swc/jest * Upgrade webpack * Add @swc/core to crdt * Use yarn cache in github actions * Cleanup * Fix electron * Revert "Fix electron" This reverts commit 787af19. * Revert action.yml cache changes --------- Co-authored-by: Matiss Janis Aboltins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #656