Goals: Check template action #1108
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
This feature is still very much experimental but I personally am a bit concerned it is bleeding out into the UI, this drop down is getting increasingly large now if goals is turned on, if goals is turned off there is only 3 options here.
I think if Goals are sticking around we need to think about a design for the UI and how this should look in a more perm position that means something to the user. |
|
I agree that menu is getting busy, and that something better needs put together. To stir the pot some more, should that menu exist at all? It makes sense to be there with the 3 non-experimental options, but not as much once templates are added. I don't think it would be bad to make a combined view for all these budget filler options like is being discussed in #1006. That way anything that isn't manual budgeting gets its own view. But that's a ways off. I'm open to suggestions of a better placement for the time being. |
|
At the moment we have options all over the place! I would suggest that the option you added in this particular PR gets moved into here
It is a check of the templates in the categories, it isn't doing anything to the budget itself which is what the other menu (below)
Seems to be for... The top menu, seems to be for options that affect the budget and the second menu is for options that affect categories, as the templates we are checking are in category notes, maybe it should be there? |
|
Would it be confusing to have the template actions be in two different places? |
Not sure, thinking out loud. Trying to work out how the flow of the app should work. Right now everything is just lumped in that menu up top.... |
|
Ultimately much of this wont matter once the templates get a UI and the goals are created by the gui. |
There was a problem hiding this comment.
I'm personally fine with merging this now and discussing UI improvements separately, since this feature is still experimental. @rich-howell any objections to that?
trafico-bot
bot
added
✨ Merged
This adds an option to the month drop down to check all the template lines. If there are errors the offending line is shown with its category. I also modified the wording on the regular template return to be more accurate. Fixes actualbudget#1100
This adds an option to the month drop down to check all the template lines. If there are errors the offending line is shown with its category.
I also modified the wording on the regular template return to be more accurate. Fixes #1100