Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maintenance] build script upgrade #656

Closed
1 of 2 tasks
MatissJanis opened this issue Feb 13, 2023 · 5 comments
Closed
1 of 2 tasks

[Maintenance] build script upgrade #656

MatissJanis opened this issue Feb 13, 2023 · 5 comments
Labels
tech debt Technical debt we should pay down

Comments

@MatissJanis
Copy link
Member

Verified feature request does not already exist?

  • I have searched and found no existing issue

💻

  • Would you like to implement this feature?

Pitch: what problem are you trying to solve?

We currently use a very old version of webpack. We should either upgrade it + the other dependencies or move to a better build system.

Some alternatives to consider:

  • esbuild
  • vite
  • back to create-react-app managed version
  • swc
  • ?

Some more info:
https://github.com/actualbudget/actual/blob/40a23f326341b665298561f4dbd8b4d8296e3365/CONTRIBUTING.md#ditching-babel

Describe your ideal solution to this problem

No response

Teaching and learning

No response

@j-f1
Copy link
Contributor

j-f1 commented Feb 13, 2023

@MatissJanis MatissJanis added help wanted Extra attention is needed tech debt Technical debt we should pay down priority:high and removed needs triage feature This issue is a feature request labels Feb 15, 2023
@MatissJanis
Copy link
Member Author

desktop-client has been moved back to CRA.

We still need to figure out a solution for loot-core. Maybe we should consider rollup for it? Or another bundler that's good for building small libraries? TBD

@j-f1
Copy link
Contributor

j-f1 commented Jun 15, 2023

Current status: we’re using the latest version of Webpack at the moment for all packages. I think we’re in a much better place than we were before, but it would be nice to switch to something that builds a bit faster so development can be easier.

@MikesGlitch
Copy link
Contributor

MikesGlitch commented Dec 8, 2023

My vote is for Vite because of its build speed, community, and easy config.

I've never used SWC - it looks interesting...

@MatissJanis
Copy link
Member Author

We're now using vite which is a significant improvement.

@github-actions github-actions bot removed the help wanted Extra attention is needed label Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt Technical debt we should pay down
Projects
None yet
Development

No branches or pull requests

3 participants