Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feedback]: Sankey Chart #1919

Closed
4 tasks
shaankhosla opened this issue Nov 16, 2023 · 24 comments · Fixed by #2417
Closed
4 tasks

[Feedback]: Sankey Chart #1919

shaankhosla opened this issue Nov 16, 2023 · 24 comments · Fixed by #2417
Labels
experimental feature Related to an experimental feature feedback Single feedback thread for bug reports on a new feature

Comments

@shaankhosla
Copy link
Contributor

shaankhosla commented Nov 16, 2023

Known issues:

  • In cases where there are many income payees, expense groups, or expense categories, the Sankey chart can look a bit wonky, and not fully fit in the component.

Upcoming additions:

  • Group together small nodes into an "Other" category at each level. This will fix the issue mentioned above regarding too many small nodes.
  • Add theme colors
  • Privacy blocks
@shaankhosla shaankhosla added the bug Something isn't working label Nov 16, 2023
@carkom
Copy link
Contributor

carkom commented Nov 17, 2023

This is a cool graph, I love the idea!

It needs to add theme colors and privacy blocks to enable those features for this chart. Needs done on chart page as well as overview card. Cheers!

@shaankhosla
Copy link
Contributor Author

Great points, agreed. I'll add those above.

@Redbox3070
Copy link

Sick chart!
I would like to have percentage % on Budget instead of the absolute value in labels. Absolute value could be shown on hover.
I think the choice of displaying <1k was due to space constraints but is not that useful if most of your categories are below 1k. This one is a great example of more meaningful labels https://i.redd.it/x4xib51xxsv21.png

  • my largest payee is not displayed
    sankey

@youngcw youngcw pinned this issue Nov 19, 2023
@MatissJanis MatissJanis added experimental feature Related to an experimental feature feedback Single feedback thread for bug reports on a new feature and removed bug Something isn't working labels Nov 20, 2023
@Akellade
Copy link

It would be neat if there was a bit more control of the level of detail shown, For instance toggling showing the final categories
right now it's shown as :
Income categories > Budget > Outgoing Groups > Outgoing categories.
It's quite a good graph for hiding the outgoing categories or even income categories to just show how the budget was used at a higher level.

@MatissJanis
Copy link
Member

Nice to haves:

  • add "unspent income" (for the lack of better naming) - a category group that captures the result of "income - expenses"; for example: I "hold for next month" a part of my income - currently this amount does not show up in the sankey graph
  • ability to show/hide the categories - leaving only the category group level visible (but maybe this won't be as pressing if we have grouping of small amounts under "other")

@MatissJanis
Copy link
Member

Bug (possibly applicable to other reports too):

payees not showing up when filtering

Screen.Recording.2023-11-27.at.19.59.25.mov

@Teprifer
Copy link

Teprifer commented Dec 2, 2023

Looks nifty, thanks for working on this.

My 2 cents:
Bigger font for the labels, both category/sources and for the actual amount
Percentages beside label(or amount)

image

I notice the right side of budget the output doesn't extend the full way down, is this money added to the budget but not spent? If so I'd create a ghost category or a label to indicate this, as otherwise it looks like something is missing.
Ditto for indicating un-budgeted funds.

@Teprifer
Copy link

Teprifer commented Dec 3, 2023

Feature request, option to end the graph at Category Group level. This will allow better scaling and a nice high level view.

@leouzz
Copy link

leouzz commented Jan 5, 2024

All the incoms should flow insider a container "income". Then incombe + residual budget (previous periodo) = budget... Then add 1 output "remaining budget" (not spent)

@MatissJanis
Copy link
Member

@shaankhosla what's the plan with the sankey graph? If we can't get it in as a stable feature I'd be inclined to cut it. Experimental features aren't meant to live around forever.

@youngcw
Copy link
Member

youngcw commented Jan 21, 2024

I think the only thing that needs an update would be the dark mode colors. Everything else seems to be just nice to have additions.

@shaankhosla
Copy link
Contributor Author

Yep I agree, theme colors and the privacy blocks are critical. I'll work on adding those.

@egelmex
Copy link

egelmex commented Jan 23, 2024

Enjoying the sankey report, it's really handy to see if my catagories are roughly sane, if one gets too big like I am throwing things in general I can see at a glance that it might need splitting. Came here to say privacy bloicks are not working, but looks like that's already known. Wanted to show off the feature but not the values .

@Redbox3070
Copy link

Redbox3070 commented Jan 25, 2024

I have an issue, the income from my employer (payee "employer inc") goes to 2 different accounts ("account a", "account b") every month. Unfortunately on the sankey it only shows income that flows to "account b". My workaround is to set 2 different payees.

my largest payee is not displayed
sankey

I also believe that showing "<1k" makes the category breakdown cluttered and meaningless. The easiest solution would be to add decimal, "0.9k" uses the same space but is way more meaningful. Percentages would work well too.

@jamescostian
Copy link
Contributor

Screenshot 2024-02-08 at 9 30 27 PM

I'm wondering if there's a small bug in how the expense categories are sorted. I have 2 expense groups and when it branches off of them to show the individual expense categories in the pic above, they mostly are sorted like "categories from the first group first (sorted by amount descending), then categories from the second group (sorted by amount descending)". However, the top red arrow shows a time when this trend is broken, making it seem like the real rule is "categories are sorted by amount spent, descending, with no care given to group". But looking at my next red arrow, we see 2 more lines that very clearly should be moved up by that logic.

But the bigger concern I have is missing data - I have 15 expense categories, yet the above sankey chart only shows 14. I'm not sure why. The missing category is a bit on the smaller side but there are smaller ones in its same expense group.

After some manual testing, I've found a way to get the 15th category to reveal itself - the final month dropdown cannot be set to this month or the month before, but the one before (December) or earlier, and the initial month dropdown has the same behavior but in reverse (my first entry is in May 2021, I must set the initial date to July 2021 or later). Using these settings allowed me to get this output (the category that was missing is the one the tip of the arrow just barely touches):

Screenshot 2024-02-08 at 9 41 19 PM

You also might notice another interesting artifact in the above screenshot - that previously missing category is actually a bit larger than the category above it. You can see it visually in this screenshot, and the numbers on the far right of the sankey chart confirm it. Yet, it is somehow sorted to be lower. Not sure how relevant this is, but fwiw, there are a non-trivial amount of deposits in that category in addition to expenses in it - perhaps it's getting confused there?

@niko123456000
Copy link

I would like all the "income" to come from the Income category, instead of from the Payee. The reason is because my payee names are often different and it's a hassle trying to standardise the payee name of deposits just so it appears properly in the Sankey diagram. I think using the Category is a better way. Does anyone agree or have another suggestion?

@Teprifer
Copy link

Teprifer commented Feb 16, 2024

I would like all the "income" to come from the Income category, instead of from the Payee. The reason is because my payee names are often different and it's a hassle trying to standardise the payee name of deposits just so it appears properly in the Sankey diagram. I think using the Category is a better way. Does anyone agree or have another suggestion?

I think it's a good idea, but needing to keep in mind some people may want to know the proportion of their income sources. Maybe a 'group income sources' toggle?

/ed/ Actually in hindsight for my comment, it doesn't make sense they aren't grouped by category in the first place given the rest is by category. If people want to represent different sources, they likely already have different categories.

@MatissJanis
Copy link
Member

👋 This feature hasn't been worked on in a very long time. As per the new experimental feature flag policy - we'll be removing it soon unless someone picks it up again.

MatissJanis added a commit that referenced this issue Mar 3, 2024
@youngcw youngcw unpinned this issue Mar 4, 2024
MatissJanis added a commit that referenced this issue Mar 6, 2024
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this issue Mar 7, 2024
@sandu-c
Copy link

sandu-c commented Apr 7, 2024

👋 This feature hasn't been worked on in a very long time. As per the new experimental feature flag policy - we'll be removing it soon unless someone picks it up again.

very sorry to hear that, this was an awesome report chart

@SamRodkey
Copy link

I miss this feature! I feel like it was the first report that actually helped me get a handle on the big picture!

@aChrisYouKnow
Copy link

Fingers crossed someone can bring it back

@Treawlony
Copy link

For what it worth, I'd like to bump it too.

@CrO2Cl2
Copy link

CrO2Cl2 commented Dec 8, 2024

Bumping this feature up, this is such a great chart

@dkhalife
Copy link

I'm ramping up on the codebase and a big fan of this type of chart. I intend to reimplement this feature once I've learned enough about the codebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental feature Related to an experimental feature feedback Single feedback thread for bug reports on a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.