Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maintenance] Delete unused variables #1907

Closed
MatissJanis opened this issue Nov 14, 2023 · 2 comments · Fixed by #2256
Closed

[Maintenance] Delete unused variables #1907

MatissJanis opened this issue Nov 14, 2023 · 2 comments · Fixed by #2256
Labels
good first issue Good for newcomers maintenance Related to making the project easier to maintain

Comments

@MatissJanis
Copy link
Member

We currently use @typescript-eslint/no-unused-vars eslint rule which is enabled for most things. However, it is disabled for args.

The overall goal here would be to re-enable @typescript-eslint/no-unused-vars for args. Thus disallowing unuser arguments.

actual/.eslintrc.js

Line 54 in 08c80b6

args: 'none',

Please do not do this as one-big-bang migration.
@MatissJanis MatissJanis added good first issue Good for newcomers help wanted Extra attention is needed maintenance Related to making the project easier to maintain labels Nov 14, 2023
@Sahad-09
Copy link

I'm working on it

@jaas666 jaas666 mentioned this issue Nov 18, 2023
Closed
@jaas666
Copy link

jaas666 commented Nov 18, 2023

Sorry, didn't saw earlier that @Sahad-09 was working on this. Feel free to close my PR in favor of his.

This was referenced Jan 19, 2024
Merged
Merged
@github-actions github-actions bot removed the help wanted Extra attention is needed label Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers maintenance Related to making the project easier to maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🔥 removing unused variables (batch 2) actualbudget/actual
Remove unused args
3 participants
@MatissJanis @jaas666 @Sahad-09