ESLint no-default-export 13 - final

actualbudget · Jan 6, 2024 · e2bcc08 · e2bcc08
1 parent 535ab35
commit e2bcc08
Show file tree

Hide file tree

Showing 29 changed files with 50 additions and 80 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -165,7 +165,7 @@ module.exports = {
     'prefer-const': 'warn',
     'prefer-spread': 'off',
     '@typescript-eslint/no-empty-function': 'off',
-    'import/no-default-export': 'off',
+    'import/no-default-export': 'warn',
   },
   overrides: [
     {
@@ -241,23 +241,10 @@ module.exports = {
     },
     {
       files: [
-        './packages/api/*',
-        './packages/api/app/**/*',
-        './packages/crdt/**/*',
-        './packages/desktop-client/**/*',
-        './packages/desktop-electron/**/*',
-        './packages/eslint-plugin-actual/**/*',
-        './packages/loot-core/*',
-        './packages/loot-core/src/*',
-        './packages/loot-core/src/client/**/*',
-        './packages/loot-core/src/mocks/**/*',
-        './packages/loot-core/src/platform/**/*',
-        // './packages/loot-core/src/server/**/*',
-        './packages/loot-core/src/shared/**/*',
-        './packages/loot-core/src/types/**/*',
+        './packages/loot-core/migrations/*',
       ],
       rules: {
-        'import/no-default-export': 'warn',
+        'import/no-default-export': 'off',
       },
     },
   ],

diff --git a/packages/loot-core/src/server/accounts/ofx2json.ts b/packages/loot-core/src/server/accounts/ofx2json.ts
@@ -110,7 +110,7 @@ function mapOfxTransaction(stmtTrn): OFXTransaction {
   };
 }
 
-export default async function parse(ofx: string): Promise<OFXParseResult> {
+export async function ofx2json(ofx: string): Promise<OFXParseResult> {
   // firstly, split into the header attributes and the footer sgml
   const contents = ofx.split('<OFX>', 2);
 

diff --git a/packages/loot-core/src/server/accounts/parse-file.ts b/packages/loot-core/src/server/accounts/parse-file.ts
@@ -4,8 +4,8 @@ import * as fs from '../../platform/server/fs';
 import { dayFromDate } from '../../shared/months';
 import { looselyParseAmount } from '../../shared/util';
 
-import ofx2json from './ofx2json';
-import qif2json from './qif2json';
+import { ofx2json } from './ofx2json';
+import { qif2json } from './qif2json';
 
 type ParseError = { message: string; internal: string };
 export type ParseFileResult = {

diff --git a/packages/loot-core/src/server/accounts/qif2json.ts b/packages/loot-core/src/server/accounts/qif2json.ts
@@ -18,7 +18,7 @@ type QIFTransaction = {
   division?: Division[];
 };
 
-export default function parse(qif, options: { dateFormat?: string } = {}) {
+export function qif2json(qif, options: { dateFormat?: string } = {}) {
   const lines = qif.split('\n');
   let line = lines.shift();
   const type = /!Type:([^$]*)$/.exec(line.trim());

diff --git a/packages/loot-core/src/server/accounts/sync.ts b/packages/loot-core/src/server/accounts/sync.ts
@@ -15,7 +15,7 @@ import { getServer } from '../server-config';
 import { batchMessages } from '../sync';
 
 import { getStartingBalancePayee } from './payees';
-import title from './title';
+import { title } from './title';
 import { runRules } from './transaction-rules';
 import { batchUpdateTransactions } from './transactions';
 

diff --git a/packages/loot-core/src/server/accounts/title/index.ts b/packages/loot-core/src/server/accounts/title/index.ts
@@ -1,6 +1,6 @@
 // Utilities
-import lowerCase from './lower-case';
-import specials from './specials';
+import { lowerCaseSet } from './lower-case';
+import { specials } from './specials';
 
 const character =
   '[0-9\u0041-\u005A\u0061-\u007A\u00AA\u00B5\u00BA\u00C0-\u00D6\u00D8-\u00F6\u00F8-\u02C1\u02C6-\u02D1\u02E0-\u02E4\u02EC\u02EE\u0370-\u0374\u0376-\u0377\u037A-\u037D\u0386\u0388-\u038A\u038C\u038E-\u03A1\u03A3-\u03F5\u03F7-\u0481\u048A-\u0523\u0531-\u0556\u0559\u0561-\u0587\u05D0-\u05EA\u05F0-\u05F2\u0621-\u064A\u066E-\u066F\u0671-\u06D3\u06D5\u06E5-\u06E6\u06EE-\u06EF\u06FA-\u06FC\u06FF\u0710\u0712-\u072F\u074D-\u07A5\u07B1\u07CA-\u07EA\u07F4-\u07F5\u07FA\u0904-\u0939\u093D\u0950\u0958-\u0961\u0971-\u0972\u097B-\u097F\u0985-\u098C\u098F-\u0990\u0993-\u09A8\u09AA-\u09B0\u09B2\u09B6-\u09B9\u09BD\u09CE\u09DC-\u09DD\u09DF-\u09E1\u09F0-\u09F1\u0A05-\u0A0A\u0A0F-\u0A10\u0A13-\u0A28\u0A2A-\u0A30\u0A32-\u0A33\u0A35-\u0A36\u0A38-\u0A39\u0A59-\u0A5C\u0A5E\u0A72-\u0A74\u0A85-\u0A8D\u0A8F-\u0A91\u0A93-\u0AA8\u0AAA-\u0AB0\u0AB2-\u0AB3\u0AB5-\u0AB9\u0ABD\u0AD0\u0AE0-\u0AE1\u0B05-\u0B0C\u0B0F-\u0B10\u0B13-\u0B28\u0B2A-\u0B30\u0B32-\u0B33\u0B35-\u0B39\u0B3D\u0B5C-\u0B5D\u0B5F-\u0B61\u0B71\u0B83\u0B85-\u0B8A\u0B8E-\u0B90\u0B92-\u0B95\u0B99-\u0B9A\u0B9C\u0B9E-\u0B9F\u0BA3-\u0BA4\u0BA8-\u0BAA\u0BAE-\u0BB9\u0BD0\u0C05-\u0C0C\u0C0E-\u0C10\u0C12-\u0C28\u0C2A-\u0C33\u0C35-\u0C39\u0C3D\u0C58-\u0C59\u0C60-\u0C61\u0C85-\u0C8C\u0C8E-\u0C90\u0C92-\u0CA8\u0CAA-\u0CB3\u0CB5-\u0CB9\u0CBD\u0CDE\u0CE0-\u0CE1\u0D05-\u0D0C\u0D0E-\u0D10\u0D12-\u0D28\u0D2A-\u0D39\u0D3D\u0D60-\u0D61\u0D7A-\u0D7F\u0D85-\u0D96\u0D9A-\u0DB1\u0DB3-\u0DBB\u0DBD\u0DC0-\u0DC6\u0E01-\u0E30\u0E32-\u0E33\u0E40-\u0E46\u0E81-\u0E82\u0E84\u0E87-\u0E88\u0E8A\u0E8D\u0E94-\u0E97\u0E99-\u0E9F\u0EA1-\u0EA3\u0EA5\u0EA7\u0EAA-\u0EAB\u0EAD-\u0EB0\u0EB2-\u0EB3\u0EBD\u0EC0-\u0EC4\u0EC6\u0EDC-\u0EDD\u0F00\u0F40-\u0F47\u0F49-\u0F6C\u0F88-\u0F8B\u1000-\u102A\u103F\u1050-\u1055\u105A-\u105D\u1061\u1065-\u1066\u106E-\u1070\u1075-\u1081\u108E\u10A0-\u10C5\u10D0-\u10FA\u10FC\u1100-\u1159\u115F-\u11A2\u11A8-\u11F9\u1200-\u1248\u124A-\u124D\u1250-\u1256\u1258\u125A-\u125D\u1260-\u1288\u128A-\u128D\u1290-\u12B0\u12B2-\u12B5\u12B8-\u12BE\u12C0\u12C2-\u12C5\u12C8-\u12D6\u12D8-\u1310\u1312-\u1315\u1318-\u135A\u1380-\u138F\u13A0-\u13F4\u1401-\u166C\u166F-\u1676\u1681-\u169A\u16A0-\u16EA\u16EE-\u16F0\u1700-\u170C\u170E-\u1711\u1720-\u1731\u1740-\u1751\u1760-\u176C\u176E-\u1770\u1780-\u17B3\u17D7\u17DC\u1820-\u1877\u1880-\u18A8\u18AA\u1900-\u191C\u1950-\u196D\u1970-\u1974\u1980-\u19A9\u19C1-\u19C7\u1A00-\u1A16\u1B05-\u1B33\u1B45-\u1B4B\u1B83-\u1BA0\u1BAE-\u1BAF\u1C00-\u1C23\u1C4D-\u1C4F\u1C5A-\u1C7D\u1D00-\u1DBF\u1E00-\u1F15\u1F18-\u1F1D\u1F20-\u1F45\u1F48-\u1F4D\u1F50-\u1F57\u1F59\u1F5B\u1F5D\u1F5F-\u1F7D\u1F80-\u1FB4\u1FB6-\u1FBC\u1FBE\u1FC2-\u1FC4\u1FC6-\u1FCC\u1FD0-\u1FD3\u1FD6-\u1FDB\u1FE0-\u1FEC\u1FF2-\u1FF4\u1FF6-\u1FFC\u2071\u207F\u2090-\u2094\u2102\u2107\u210A-\u2113\u2115\u2119-\u211D\u2124\u2126\u2128\u212A-\u212D\u212F-\u2139\u213C-\u213F\u2145-\u2149\u214E\u2160-\u2188\u2C00-\u2C2E\u2C30-\u2C5E\u2C60-\u2C6F\u2C71-\u2C7D\u2C80-\u2CE4\u2D00-\u2D25\u2D30-\u2D65\u2D6F\u2D80-\u2D96\u2DA0-\u2DA6\u2DA8-\u2DAE\u2DB0-\u2DB6\u2DB8-\u2DBE\u2DC0-\u2DC6\u2DC8-\u2DCE\u2DD0-\u2DD6\u2DD8-\u2DDE\u2E2F\u3005-\u3007\u3021-\u3029\u3031-\u3035\u3038-\u303C\u3041-\u3096\u309D-\u309F\u30A1-\u30FA\u30FC-\u30FF\u3105-\u312D\u3131-\u318E\u31A0-\u31B7\u31F0-\u31FF\u3400\u4DB5\u4E00\u9FC3\uA000-\uA48C\uA500-\uA60C\uA610-\uA61F\uA62A-\uA62B\uA640-\uA65F\uA662-\uA66E\uA67F-\uA697\uA717-\uA71F\uA722-\uA788\uA78B-\uA78C\uA7FB-\uA801\uA803-\uA805\uA807-\uA80A\uA80C-\uA822\uA840-\uA873\uA882-\uA8B3\uA90A-\uA925\uA930-\uA946\uAA00-\uAA28\uAA40-\uAA42\uAA44-\uAA4B\uAC00\uD7A3\uF900-\uFA2D\uFA30-\uFA6A\uFA70-\uFAD9\uFB00-\uFB06\uFB13-\uFB17\uFB1D\uFB1F-\uFB28\uFB2A-\uFB36\uFB38-\uFB3C\uFB3E\uFB40-\uFB41\uFB43-\uFB44\uFB46-\uFBB1\uFBD3-\uFD3D\uFD50-\uFD8F\uFD92-\uFDC7\uFDF0-\uFDFB\uFE70-\uFE74\uFE76-\uFEFC\uFF21-\uFF3A\uFF41-\uFF5A\uFF66-\uFFBE\uFFC2-\uFFC7\uFFCA-\uFFCF\uFFD2-\uFFD7\uFFDA-\uFFDC]';
@@ -28,7 +28,7 @@ function parseMatch(match) {
   return match;
 }
 
-export default function title(str, options = { special: undefined }) {
+export function title(str, options = { special: undefined }) {
   str = str
     .toLowerCase()
     .replace(regex, (m, lead = '', forced, lower, rest) => {
@@ -39,7 +39,7 @@ export default function title(str, options = { special: undefined }) {
       if (!forced) {
         const fullLower = lower + rest;
 
-        if (lowerCase.has(fullLower)) {
+        if (lowerCaseSet.has(fullLower)) {
           return parsedMatch;
         }
       }

diff --git a/packages/loot-core/src/server/accounts/title/lower-case.ts b/packages/loot-core/src/server/accounts/title/lower-case.ts
@@ -86,5 +86,8 @@ const prepositions = [
   'without',
 ];
 
-const dictionary = new Set([...conjunctions, ...articles, ...prepositions]);
-export default dictionary;
+export const lowerCaseSet = new Set([
+  ...conjunctions,
+  ...articles,
+  ...prepositions,
+]);
diff --git a/packages/loot-core/src/server/accounts/title/specials.ts b/packages/loot-core/src/server/accounts/title/specials.ts
@@ -1,4 +1,4 @@
-const intended = [
+export const specials = [
   'CLI',
   'API',
   'HTTP',
@@ -19,5 +19,3 @@ const intended = [
   'Next.js',
   'Node.js',
 ];
-
-export default intended;
diff --git a/packages/loot-core/src/server/api.ts b/packages/loot-core/src/server/api.ts
@@ -602,7 +602,7 @@ handlers['api/payee-delete'] = withMutation(async function ({ id }) {
   return handlers['payees-batch-change']({ deleted: [{ id }] });
 });
 
-export default function installAPI(serverHandlers: ServerHandlers) {
+export function installAPI(serverHandlers: ServerHandlers) {
   const merged = Object.assign({}, serverHandlers, handlers);
   handlers = merged as Handlers;
   return merged;

diff --git a/packages/loot-core/src/server/budget/app.ts b/packages/loot-core/src/server/budget/app.ts
@@ -7,7 +7,7 @@ import * as cleanupActions from './cleanup-template';
 import * as goalActions from './goaltemplates';
 import { BudgetHandlers } from './types/handlers';
 
-const app = createApp<BudgetHandlers>();
+export const app = createApp<BudgetHandlers>();
 
 app.method('budget/budget-amount', mutator(undoable(actions.setBudget)));
 app.method(
@@ -62,5 +62,3 @@ app.method(
   'budget/set-carryover',
   mutator(undoable(actions.setCategoryCarryover)),
 );
-
-export default app;
diff --git a/packages/loot-core/src/server/filters/app.ts b/packages/loot-core/src/server/filters/app.ts
@@ -170,10 +170,8 @@ async function deleteFilter(id) {
   await db.delete_('transaction_filters', id);
 }
 
-const app = createApp<FiltersHandlers>();
+export const app = createApp<FiltersHandlers>();
 
 app.method('filter-create', mutator(createFilter));
 app.method('filter-update', mutator(updateFilter));
 app.method('filter-delete', mutator(undoable(deleteFilter)));
-
-export default app;
diff --git a/packages/loot-core/src/server/importers/actual.ts b/packages/loot-core/src/server/importers/actual.ts
@@ -4,7 +4,7 @@ import * as cloudStorage from '../cloud-storage';
 import { handlers } from '../main';
 import { waitOnSpreadsheet } from '../sheet';
 
-export default async function importActual(_filepath: string, buffer: Buffer) {
+export async function importActual(_filepath: string, buffer: Buffer) {
   // Importing Actual files is a special case because we can directly
   // write down the files, but because it doesn't go through the API
   // layer we need to duplicate some of the workflow

diff --git a/packages/loot-core/src/server/importers/index.ts b/packages/loot-core/src/server/importers/index.ts
@@ -1,6 +1,6 @@
 import { handlers } from '../main';
 
-import importActual from './actual';
+import { importActual } from './actual';
 import * as YNAB4 from './ynab4';
 import * as YNAB5 from './ynab5';
 

diff --git a/packages/loot-core/src/server/main-app.ts b/packages/loot-core/src/server/main-app.ts
@@ -4,10 +4,8 @@ import { Handlers } from '../types/handlers';
 import { createApp } from './app';
 
 // Main app
-const app = createApp<Handlers>();
+export const app = createApp<Handlers>();
 
 app.events.on('sync', info => {
   connection.send('sync-event', info);
 });
-
-export default app;
diff --git a/packages/loot-core/src/server/main.ts b/packages/loot-core/src/server/main.ts
@@ -23,7 +23,7 @@ import { getStartingBalancePayee } from './accounts/payees';
 import * as bankSync from './accounts/sync';
 import * as rules from './accounts/transaction-rules';
 import { batchUpdateTransactions } from './accounts/transactions';
-import installAPI from './api';
+import { installAPI } from './api';
 import { runQuery as aqlQuery } from './aql';
 import {
   getAvailableBackups,
@@ -32,23 +32,23 @@ import {
   startBackupService,
   stopBackupService,
 } from './backups';
-import budgetApp from './budget/app';
+import { app as budgetApp } from './budget/app';
 import * as budget from './budget/base';
 import * as cloudStorage from './cloud-storage';
 import * as db from './db';
 import * as mappings from './db/mappings';
 import * as encryption from './encryption';
 import { APIError, TransactionError, PostError } from './errors';
-import filtersApp from './filters/app';
+import { app as filtersApp } from './filters/app';
 import { handleBudgetImport } from './importers';
-import app from './main-app';
+import { app } from './main-app';
 import { mutator, runHandler } from './mutators';
-import notesApp from './notes/app';
+import { app as notesApp } from './notes/app';
 import * as Platform from './platform';
 import { get, post } from './post';
 import * as prefs from './prefs';
-import rulesApp from './rules/app';
-import schedulesApp from './schedules/app';
+import { app as rulesApp } from './rules/app';
+import { app as schedulesApp } from './schedules/app';
 import { getServer, setServer } from './server-config';
 import * as sheet from './sheet';
 import { resolveName, unresolveName } from './spreadsheet/util';
@@ -63,7 +63,7 @@ import {
   repairSync,
 } from './sync';
 import * as syncMigrations from './sync/migrate';
-import toolsApp from './tools/app';
+import { app as toolsApp } from './tools/app';
 import { withUndo, clearUndo, undo, redo } from './undo';
 import { updateVersion } from './update';
 import { uniqueFileName, idFromFileName } from './util/budget-name';

diff --git a/packages/loot-core/src/server/notes/app.ts b/packages/loot-core/src/server/notes/app.ts
@@ -3,10 +3,8 @@ import * as db from '../db';
 
 import { NotesHandlers } from './types/handlers';
 
-const app = createApp<NotesHandlers>();
+export const app = createApp<NotesHandlers>();
 
 app.method('notes-save', async ({ id, note }) => {
   await db.update('notes', { id, note });
 });
-
-export default app;
diff --git a/packages/loot-core/src/server/rules/app.ts b/packages/loot-core/src/server/rules/app.ts
@@ -67,7 +67,7 @@ function validateRule(rule: Partial<RuleEntity>) {
 }
 
 // Expose functions to the client
-const app = createApp<RulesHandlers>();
+export const app = createApp<RulesHandlers>();
 
 app.method('rule-validate', async function (rule) {
   const error = validateRule(rule);
@@ -153,5 +153,3 @@ app.method('rule-get', async function ({ id }) {
 app.method('rules-run', async function ({ transaction }) {
   return rules.runRules(transaction);
 });
-
-export default app;
diff --git a/packages/loot-core/src/server/schedules/app.ts b/packages/loot-core/src/server/schedules/app.ts
@@ -543,7 +543,7 @@ async function advanceSchedulesService(syncSuccess) {
 }
 
 // Expose functions to the client
-const app = createApp<SchedulesHandlers>();
+export const app = createApp<SchedulesHandlers>();
 
 app.method('schedule/create', mutator(undoable(createSchedule)));
 app.method('schedule/update', mutator(undoable(updateSchedule)));
@@ -592,5 +592,3 @@ export function getDateWithSkippedWeekend(
   }
   return date;
 }
-
-export default app;
diff --git a/packages/loot-core/src/server/sheet.ts b/packages/loot-core/src/server/sheet.ts
@@ -6,7 +6,7 @@ import { sheetForMonth } from '../shared/months';
 
 import * as Platform from './platform';
 import * as prefs from './prefs';
-import Spreadsheet from './spreadsheet/spreadsheet';
+import { Spreadsheet } from './spreadsheet/spreadsheet';
 import { resolveName } from './spreadsheet/util';
 
 let globalSheet: Spreadsheet;

diff --git a/packages/loot-core/src/server/spreadsheet/graph-data-structure.ts b/packages/loot-core/src/server/spreadsheet/graph-data-structure.ts
@@ -1,4 +1,4 @@
-function Graph() {
+export function Graph() {
   const graph = {
     addNode,
     removeNode,
@@ -120,5 +120,3 @@ function Graph() {
 
   return graph;
 }
-
-export default Graph;
diff --git a/packages/loot-core/src/server/spreadsheet/spreadsheet.test.ts b/packages/loot-core/src/server/spreadsheet/spreadsheet.test.ts
@@ -1,7 +1,7 @@
 import { generateTransaction } from '../../mocks';
 import * as db from '../db';
 
-import Spreadsheet from './spreadsheet';
+import { Spreadsheet } from './spreadsheet';
 
 beforeEach(global.emptyDatabase());
 

diff --git a/packages/loot-core/src/server/spreadsheet/spreadsheet.ts b/packages/loot-core/src/server/spreadsheet/spreadsheet.ts
@@ -2,7 +2,7 @@ import mitt from 'mitt';
 
 import { compileQuery, runCompiledQuery, schema, schemaConfig } from '../aql';
 
-import Graph from './graph-data-structure';
+import { Graph } from './graph-data-structure';
 import { unresolveName, resolveName } from './util';
 
 export type Node = {
@@ -17,7 +17,7 @@ export type Node = {
   _dependencies?: string[];
 };
 
-export default class Spreadsheet {
+export class Spreadsheet {
   _meta;
   cacheBarrier;
   computeQueue;

diff --git a/packages/loot-core/src/server/sync/index.ts b/packages/loot-core/src/server/sync/index.ts
@@ -16,7 +16,7 @@ import { LocalPrefs } from '../../types/prefs';
 import { triggerBudgetChanges, setType as setBudgetType } from '../budget/base';
 import * as db from '../db';
 import { PostError, SyncError } from '../errors';
-import app from '../main-app';
+import { app } from '../main-app';
 import { runMutator } from '../mutators';
 import { postBinary } from '../post';
 import * as prefs from '../prefs';
@@ -28,9 +28,9 @@ import * as encoder from './encoder';
 import { rebuildMerkleHash } from './repair';
 import { isError } from './utils';
 
-export { default as makeTestMessage } from './make-test-message';
-export { default as resetSync } from './reset';
-export { default as repairSync } from './repair';
+export { makeTestMessage } from './make-test-message';
+export { resetSync } from './reset';
+export { repairSync } from './repair';
 
 const FULL_SYNC_DELAY = 1000;
 let SYNCING_MODE = 'enabled';

diff --git a/packages/loot-core/src/server/sync/make-test-message.ts b/packages/loot-core/src/server/sync/make-test-message.ts
@@ -6,7 +6,7 @@ async function randomString() {
   return (await encryption.randomBytes(12)).toString();
 }
 
-export default async function makeTestMessage(keyId) {
+export async function makeTestMessage(keyId) {
   const messagePb = new SyncProtoBuf.Message();
   messagePb.setDataset(await randomString());
   messagePb.setRow(await randomString());

diff --git a/packages/loot-core/src/server/sync/repair.ts b/packages/loot-core/src/server/sync/repair.ts
@@ -23,7 +23,7 @@ export function rebuildMerkleHash(): {
   };
 }
 
-export default async function repairSync(): Promise<void> {
+export async function repairSync(): Promise<void> {
   const rebuilt = rebuildMerkleHash();
   const clock = getClock();
 

diff --git a/packages/loot-core/src/server/sync/reset.ts b/packages/loot-core/src/server/sync/reset.ts
@@ -6,7 +6,7 @@ import * as db from '../db';
 import { runMutator } from '../mutators';
 import * as prefs from '../prefs';
 
-export default async function resetSync(
+export async function resetSync(
   keyState?,
 ): Promise<{ error?: { reason: string; meta?: unknown } }> {
   if (!keyState) {

diff --git a/packages/loot-core/src/server/tools/app.ts b/packages/loot-core/src/server/tools/app.ts
@@ -5,7 +5,7 @@ import { runMutator } from '../mutators';
 
 import { ToolsHandlers } from './types/handlers';
 
-const app = createApp<ToolsHandlers>();
+export const app = createApp<ToolsHandlers>();
 
 app.method('tools/fix-split-transactions', async () => {
   // 1. Check for child transactions that have a blank payee, and set
@@ -59,5 +59,3 @@ app.method('tools/fix-split-transactions', async () => {
     numDeleted: deletedRows.length,
   };
 });
-
-export default app;