Padding changes + VRT

actualbudget · Nov 1, 2024 · ce3be9f · ce3be9f
1 parent 5c3798c
commit ce3be9f
Show file tree

Hide file tree

Showing 17 changed files with 15 additions and 16 deletions.
diff --git a/...dividual-account-page-and-checks-that-filtering-is-working-1-chromium-linux.png b/...dividual-account-page-and-checks-that-filtering-is-working-1-chromium-linux.png
diff --git a/...dividual-account-page-and-checks-that-filtering-is-working-2-chromium-linux.png b/...dividual-account-page-and-checks-that-filtering-is-working-2-chromium-linux.png
diff --git a/...dividual-account-page-and-checks-that-filtering-is-working-3-chromium-linux.png b/...dividual-account-page-and-checks-that-filtering-is-working-3-chromium-linux.png
diff --git a/...dividual-account-page-and-checks-that-filtering-is-working-7-chromium-linux.png b/...dividual-account-page-and-checks-that-filtering-is-working-7-chromium-linux.png
diff --git a/...dividual-account-page-and-checks-that-filtering-is-working-8-chromium-linux.png b/...dividual-account-page-and-checks-that-filtering-is-working-8-chromium-linux.png
diff --git a/...dividual-account-page-and-checks-that-filtering-is-working-9-chromium-linux.png b/...dividual-account-page-and-checks-that-filtering-is-working-9-chromium-linux.png
diff --git a/...cking--c18ad-l-redirects-to-the-category-transactions-page-1-chromium-linux.png b/...cking--c18ad-l-redirects-to-the-category-transactions-page-1-chromium-linux.png
diff --git a/...cking--e995e-l-redirects-to-the-category-transactions-page-3-chromium-linux.png b/...cking--e995e-l-redirects-to-the-category-transactions-page-3-chromium-linux.png
diff --git a/...cking--ff568-l-redirects-to-the-category-transactions-page-2-chromium-linux.png b/...cking--ff568-l-redirects-to-the-category-transactions-page-2-chromium-linux.png
diff --git a/...cking--11290-l-redirects-to-the-category-transactions-page-3-chromium-linux.png b/...cking--11290-l-redirects-to-the-category-transactions-page-3-chromium-linux.png
diff --git a/...cking--57d88-l-redirects-to-the-category-transactions-page-2-chromium-linux.png b/...cking--57d88-l-redirects-to-the-category-transactions-page-2-chromium-linux.png
diff --git a/...cking--5d90c-l-redirects-to-the-category-transactions-page-1-chromium-linux.png b/...cking--5d90c-l-redirects-to-the-category-transactions-page-1-chromium-linux.png
diff --git a/...obile-Transactions-creates-a-transaction-via-footer-button-7-chromium-linux.png b/...obile-Transactions-creates-a-transaction-via-footer-button-7-chromium-linux.png
diff --git a/...obile-Transactions-creates-a-transaction-via-footer-button-8-chromium-linux.png b/...obile-Transactions-creates-a-transaction-via-footer-button-8-chromium-linux.png
diff --git a/...obile-Transactions-creates-a-transaction-via-footer-button-9-chromium-linux.png b/...obile-Transactions-creates-a-transaction-via-footer-button-9-chromium-linux.png
diff --git a/packages/desktop-client/src/components/mobile/transactions/TransactionList.jsx b/packages/desktop-client/src/components/mobile/transactions/TransactionList.jsx
@@ -130,8 +130,6 @@ export function TransactionList({
               style={{
                 ...styles.smallText,
                 backgroundColor: theme.pageBackground,
-                borderBottom: `1px solid ${theme.tableBorder}`,
-                borderTop: `1px solid ${theme.tableBorder}`,
                 color: theme.tableHeaderText,
                 display: 'flex',
                 justifyContent: 'center',

diff --git a/packages/desktop-client/src/components/mobile/transactions/TransactionListItem.tsx b/packages/desktop-client/src/components/mobile/transactions/TransactionListItem.tsx
@@ -1,4 +1,7 @@
-import React, { type ComponentPropsWithoutRef } from 'react';
+import React, {
+  type CSSProperties,
+  type ComponentPropsWithoutRef,
+} from 'react';
 import { mergeProps } from 'react-aria';
 import { ListBoxItem } from 'react-aria-components';
 import { useSelector } from 'react-redux';
@@ -114,12 +117,16 @@ export function TransactionListItem({
 
   const prettyCategory = specialCategory || categoryName;
 
-  const textStyle = isPreview
-    ? {
-        fontStyle: 'italic',
-        color: theme.pageTextLight,
-      }
-    : {};
+  const textStyle: CSSProperties = {
+    ...styles.text,
+    fontSize: 14,
+    ...(isPreview
+      ? {
+          fontStyle: 'italic',
+          color: theme.pageTextLight,
+        }
+      : {}),
+  };
 
   return (
     <ListBoxItem textValue={id} {...props}>
@@ -157,7 +164,7 @@ export function TransactionListItem({
                 flex: 1,
                 alignItems: 'center',
                 justifyContent: 'space-between',
-                padding: '0 10px',
+                padding: '0 4px',
               }}
             >
               <View>
@@ -174,9 +181,7 @@ export function TransactionListItem({
                   )}
                   <TextOneLine
                     style={{
-                      ...styles.text,
                       ...textStyle,
-                      fontSize: 14,
                       fontWeight: isAdded ? '600' : '400',
                       ...(prettyDescription === '' && {
                         color: theme.tableTextLight,
@@ -250,11 +255,7 @@ export function TransactionListItem({
               <View style={{ justifyContent: 'center' }}>
                 <Text
                   style={{
-                    ...styles.text,
                     ...textStyle,
-                    marginLeft: 25,
-                    marginRight: 5,
-                    fontSize: 14,
                     ...makeAmountFullStyle(amount),
                   }}
                 >