Skip to content

Commit

Permalink
Reduce client build size by 1MB (#750)
Browse files Browse the repository at this point in the history
before:

```
kcab.worker.4bdc73a8d45eb2115156.js (2.1 MiB)
xfo.kcab.worker.4bdc73a8d45eb2115156.js (1010 KiB)
```

after:

```
kcab.worker.39f5fba82d7bc7477962.js (1.41 MiB)
xfo.kcab.worker.39f5fba82d7bc7477962.js (1000 KiB)
```

What’s changed:

- `loot-core` did not have a `browserslist` config, so
`@babel/preset-env` assumes we want to [transpile all the way back to
ES5](https://babeljs.io/docs/options#no-targets). I’ve removed the
`browserslist` config from each of the `package.json` files and moved it
to the root so this doesn’t happen again.
- I updated the target from `electron 3.0` to `electron 12.0` to match
our Electron dependency
- I’ve added `defaults` (currently equivalent to `> 0.5%, last 2
versions, Firefox ESR, not dead`) which is [recommended by
browserslist](https://browsersl.ist/#q=defaults). We could consider
tightening this, but it doesn’t offer a ton of space savings at this
point to just target Electron 12.
- Since much less transpilation will be happening, stack traces (dev and
prod) will be much easier to read!
  • Loading branch information
j-f1 authored Mar 14, 2023
1 parent 21f0644 commit c7e531a
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 9 deletions.
6 changes: 5 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,5 +47,9 @@
"resolutions": {
"react-error-overlay": "6.0.9"
},
"packageManager": "[email protected]"
"packageManager": "[email protected]",
"browserslist": [
"electron 12.0",
"defaults"
]
}
5 changes: 1 addition & 4 deletions packages/desktop-client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,5 @@
"<rootDir>/src/setupTests.js",
"<rootDir>/../loot-design/src/setupTests.js"
]
},
"browserslist": [
"electron 3.0"
]
}
}
5 changes: 1 addition & 4 deletions packages/loot-design/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,5 @@
"manifest": "manifest.json",
"pathAliases": {
"react-art": "../../node_modules/node-noop"
},
"browserslist": [
"electron 3.0"
]
}
}

0 comments on commit c7e531a

Please sign in to comment.