PR feedback: security

.github/workflows/i18n-string-extract-master.yml

@@ -16,14 +16,6 @@ jobs:
     - name: Configure i18n client
       run: |
         pip install wlc
-        mkdir -p ~/.config
-        cat <<EOF >~/.config/weblate
-        [weblate]
-        url = https://hosted.weblate.org/api/
-        key = ${{ secrets.WEBLATE_API_KEY_CI_STRINGS }}
-        translation = actualbudget/actual/en
-        EOF
-        chmod 600 ~/.config/weblate
     - name: Generate i18n strings
       run: yarn generate:i18n
     - name: Upload i18n strings
@@ -32,4 +24,13 @@ jobs:
           echo "File packages/desktop-client/locale/en.json not found. Ensure the file was generated correctly."
           exit 1
         fi
-        wlc upload --author-name "Actual Budget" --author-email "[email protected]" --method add --input packages/desktop-client/locale/en.json
+        wlc \
+          --url https://hosted.weblate.org/api/ \
+          --key "${{ secrets.WEBLATE_API_KEY_CI_STRINGS }}" \
+          upload \
+          --author-name "Actual Budget" \
+          --author-email "[email protected]" \
+          --method add \
+          --input packages/desktop-client/locale/en.json \
+          actualbudget/actual/en
+        echo "Translations uploaded"

packages/desktop-client/src/i18n.ts

@@ -7,7 +7,7 @@ const languages = import.meta.glob('/locale/*.json');
 
 const loadLanguage = (language: string) => {
   const path = `/locale/${language}.json`;
-  if (!languages.hasOwnProperty(path)) {
+  if (!Object.hasOwn(languages, path)) {
     console.error(`Unknown locale ${language}`);
     throw new Error(`Unknown locale ${language}`);
   }