Skip to content

Commit

Permalink
undo changes in CellValue.tsx
Browse files Browse the repository at this point in the history
  • Loading branch information
youngcw committed Nov 6, 2023
1 parent c194f53 commit a41e010
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -40,16 +40,16 @@ export default function BalanceWithCarryover({
<View style={style}>
<CellValue
binding={balance}
goalStatus={isGoalTemplatesEnabled ? goalStatus : null}
type="financial"
getStyle={makeAmountStyle}
getStyle={null}
style={{
textAlign: 'right',
...(!disabled && {
cursor: 'pointer',
':hover': { textDecoration: 'underline' },
}),
...balanceStyle,
...makeAmountStyle(useSheetValue(balance),goalStatus)

Check warning on line 52 in packages/desktop-client/src/components/budget/BalanceWithCarryover.tsx

View workflow job for this annotation

GitHub Actions / lint

Replace `goalStatus)` with `·goalStatus),`
}}
/>
{carryoverValue && (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,16 @@ import { type Binding } from '.';

type CellValueProps = {
binding: string | Binding;
goalStatus?: boolean;
type?: string;
formatter?: (value) => ReactNode;
style?: CSSProperties;
getStyle?: (value, status) => CSSProperties;
getStyle?: (value) => CSSProperties;
privacyFilter?: ConditionalPrivacyFilterProps['privacyFilter'];
['data-testid']?: string;
};

function CellValue({
binding,
goalStatus,
type,
formatter,
style,
Expand All @@ -53,7 +51,7 @@ function CellValue({
style={{
...(type === 'financial' && styles.tnum),
...style,
...(getStyle && getStyle(sheetValue, goalStatus)),
...(getStyle && getStyle(sheetValue)),
}}
data-testid={testId || fullSheetName}
data-cellname={fullSheetName}
Expand Down

0 comments on commit a41e010

Please sign in to comment.