Skip to content

Commit

Permalink
👷 (ci) adding helper comments for failed CI jobs
Browse files Browse the repository at this point in the history
  • Loading branch information
MatissJanis committed Dec 12, 2023
1 parent 9da0554 commit 8a14c71
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 1 deletion.
21 changes: 21 additions & 0 deletions .github/workflows/e2e-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,3 +66,24 @@ jobs:
name: desktop-client-test-results
path: packages/desktop-client/test-results/
retention-days: 30
- name: Find Comment
uses: peter-evans/find-comment@v2
if: failure()
id: fc
with:
issue-number: ${{ github.event.pull_request.number }}
comment-author: 'github-actions[bot]'
body-includes: visual regression tests
- name: Create comment if failed
if: failure()
uses: peter-evans/create-or-update-comment@v3
with:
comment-id: ${{ steps.fc.outputs.comment-id }}
issue-number: ${{ github.event.pull_request.number }}
body: |
:wave: Looks like VRT (visual regression tests) are failing in this PR. This indicates a visual regression in the app. It could be either a bug in this PR or a visual change introduced by changing something.
To fix this: please follow [these instructions](https://github.com/actualbudget/actual/blob/master/packages/desktop-client/README.md#visual-regression).
We look forward to reviewing this PR once all the CI jobs have passed successfully!
edit-mode: replace
2 changes: 1 addition & 1 deletion packages/desktop-client/e2e/accounts.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ test.describe('Accounts', () => {
});

const transaction = accountPage.getNthTransaction(0);
await expect(transaction.payee).toHaveText('Starting Balance');
await expect(transaction.payee).toHaveText('Starting Balance xxxx');
await expect(transaction.notes).toHaveText('');
await expect(transaction.category).toHaveText('Starting Balances');
await expect(transaction.debit).toHaveText('');
Expand Down

0 comments on commit 8a14c71

Please sign in to comment.