Mobile budget page menu VRT

actualbudget · Sep 27, 2024 · 53ccc5e · 53ccc5e
1 parent baa4312
commit 53ccc5e
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 0 deletions.
diff --git a/packages/desktop-client/e2e/budget.mobile.test.js b/packages/desktop-client/e2e/budget.mobile.test.js
@@ -75,6 +75,22 @@ budgetTypes.forEach(budgetType => {
       await expect(page).toMatchThemeScreenshots();
     });
 
+    test('checks that clicking the Actual logo in the page header opens the budget page menu', async () => {
+      const budgetPage = await navigation.goToBudgetPage();
+      await expect(budgetPage.budgetTable).toBeVisible({
+        timeout: 10000,
+      });
+
+      await budgetPage.openBudgetPageMenu();
+
+      const budgetPageMenuModal = page.getByRole('dialog');
+      const budgetPageMenuModalTitle =
+        budgetPageMenuModal.getByLabel('Modal logo');
+
+      await expect(budgetPageMenuModalTitle).toBeVisible();
+      await expect(page).toMatchThemeScreenshots();
+    });
+
     test('checks that clicking the category group name opens the category group menu modal', async () => {
       const budgetPage = await navigation.goToBudgetPage();
       await expect(budgetPage.budgetTable).toBeVisible({

diff --git a/packages/desktop-client/e2e/page-models/mobile-budget-page.js b/packages/desktop-client/e2e/page-models/mobile-budget-page.js
@@ -22,6 +22,7 @@ export class MobileBudgetPage {
     this.selectedBudgetMonthButton = this.heading.getByLabel(
       'Selected budget month',
     );
+    this.budgetPageMenuButton = page.getByLabel('Budget page menu');
 
     this.budgetTableHeader = page.getByTestId('budget-table-header');
 
@@ -74,6 +75,10 @@ export class MobileBudgetPage {
     throw new Error('Budgeted/Spent columns could not be located on the page');
   }
 
+  async openBudgetPageMenu() {
+    await this.budgetPageMenuButton.click();
+  }
+
   async getCategoryGroupNameForRow(idx) {
     return this.categoryGroupNames.nth(idx).textContent();
   }

diff --git a/packages/desktop-client/src/components/common/Modal.tsx b/packages/desktop-client/src/components/common/Modal.tsx
@@ -318,6 +318,7 @@ export function ModalHeader({
         >
           {showLogo && (
             <SvgLogo
+              aria-label="Modal logo"
               width={30}
               height={30}
               style={{ justifyContent: 'center', alignSelf: 'center' }}

diff --git a/packages/desktop-client/src/components/mobile/budget/BudgetTable.jsx b/packages/desktop-client/src/components/mobile/budget/BudgetTable.jsx
@@ -1652,6 +1652,7 @@ export function BudgetTable({
               variant="bare"
               style={{ margin: 10 }}
               onPress={onOpenBudgetPageMenu}
+              aria-label="Budget page menu"
             >
               <SvgLogo
                 style={{ color: theme.mobileHeaderText }}