Skip to content

Commit

Permalink
Release notes
Browse files Browse the repository at this point in the history
  • Loading branch information
MatissJanis committed Jan 7, 2024
1 parent c8551d5 commit 51766e8
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 23 deletions.
1 change: 1 addition & 0 deletions packages/desktop-electron/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// (I have no idea why the imports are like this. Not touching them.)
const isDev = require('electron-is-dev');
const fs = require('fs');

require('module').globalPaths.push(__dirname + '/..');

const {
Expand Down
19 changes: 3 additions & 16 deletions packages/desktop-electron/server.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,20 +9,7 @@ function getBackend() {
return require('loot-core/lib-dist/bundle.desktop.js');
}

if (process.argv[2] === '--subprocess') {
const isDev = false;
const isDev = false;

// Start the app
getBackend().initApp(isDev);
} else if (process.argv[2] === '--standalone') {
require('source-map-support').install();
getBackend().initApp(true, 'actual-standalone');
} else {
const { ipcRenderer } = require('electron');
const isDev = true;

ipcRenderer.on('set-socket', (event, { name }) => {
// Start the app
getBackend().initApp(isDev, name);
});
}
// Start the app
getBackend().initApp(isDev);
8 changes: 1 addition & 7 deletions packages/loot-core/src/client/actions/app.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { init as initConnection, send } from '../../platform/client/fetch';
import { send } from '../../platform/client/fetch';
import * as constants from '../constants';
import type {
AppState,
Expand All @@ -15,12 +15,6 @@ export function setAppState(state: Partial<AppState>): SetAppStateAction {
};
}

export function reconnect(connectionName: string) {
return () => {
initConnection(connectionName);
};
}

export function updateApp() {
return async (dispatch: Dispatch) => {
global.Actual.applyAppUpdate();
Expand Down
6 changes: 6 additions & 0 deletions upcoming-release-notes/2190.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
category: Maintenance
authors: [MatissJanis]
---

electron: move back from WebSockets to IPC for internal communications. This should improve the stability of the desktop app.

0 comments on commit 51766e8

Please sign in to comment.