feedback

actualbudget · Nov 20, 2024 · 47b3b38 · 47b3b38
1 parent eeaf6ec
commit 47b3b38
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/packages/loot-core/src/shared/rules.ts b/packages/loot-core/src/shared/rules.ts
@@ -91,13 +91,13 @@ export const FIELD_TYPES = new Map<keyof FieldValueTypes, string>(
 
 export function isValidOp(field: keyof FieldValueTypes, op: RuleConditionOp) {
   const type = FIELD_TYPES.get(field);
-  if (!type) {
-    return false;
-  }
+
+  if (!type) return false;
+  if (fieldInfo[field].disallowedOps?.has(op)) return false;
+
   return (
-    (TYPE_INFO[type].ops.includes(op) ||
-      fieldInfo[field].internalOps?.has(op)) &&
-    !fieldInfo[field].disallowedOps?.has(op)
+    TYPE_INFO[type].ops.includes(op) ||
+      fieldInfo[field].internalOps?.has(op)
   );
 }