Skip to content

Commit

Permalink
fix modal scrolling performance on mobile
Browse files Browse the repository at this point in the history
This is primarily done by removing the blur effect from the overlay, and
replacing it will a translucent black.

The blur effect performs poorly on mobile devices.
  • Loading branch information
tim-smart committed Oct 8, 2024
1 parent bdeb194 commit 47b27d4
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,8 @@ function CategoryList({
<View>
<View
style={{
overflow: 'auto',
overflowY: 'auto',
willChange: 'transform',
padding: '5px 0',
...(!embedded && { maxHeight: 175 }),
}}
Expand Down
3 changes: 2 additions & 1 deletion packages/desktop-client/src/components/common/Modal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@ export const Modal = ({
alignItems: 'center',
justifyContent: 'center',
fontSize: 14,
backdropFilter: 'blur(1px) brightness(0.9)',
backgroundColor: 'rgba(0, 0, 0, 0.2)',
willChange: 'transform',
...style,
}}
{...props}
Expand Down
6 changes: 6 additions & 0 deletions upcoming-release-notes/3343.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
category: Bugfix
authors: [tim-smart]
---

Fix slow scrolling in mobile modals

0 comments on commit 47b27d4

Please sign in to comment.