fix bad account sort order in demo (#2279)

* fix bad sort order in demo * note * add async back * fix tests * fix2 * fix3 * update vrt * fix image
actualbudget · Jan 26, 2024 · 43ebe9e · 43ebe9e
1 parent 515bdf5
commit 43ebe9e
Show file tree

Hide file tree

Showing 49 changed files with 14 additions and 9 deletions.
diff --git a/.../e2e/accounts.test.js-snapshots/Accounts-closes-an-account-1-chromium-linux.png b/.../e2e/accounts.test.js-snapshots/Accounts-closes-an-account-1-chromium-linux.png
diff --git a/.../e2e/accounts.test.js-snapshots/Accounts-closes-an-account-2-chromium-linux.png b/.../e2e/accounts.test.js-snapshots/Accounts-closes-an-account-2-chromium-linux.png
diff --git a/.../e2e/accounts.test.js-snapshots/Accounts-closes-an-account-3-chromium-linux.png b/.../e2e/accounts.test.js-snapshots/Accounts-closes-an-account-3-chromium-linux.png
diff --git a/.../e2e/accounts.test.js-snapshots/Accounts-closes-an-account-4-chromium-linux.png b/.../e2e/accounts.test.js-snapshots/Accounts-closes-an-account-4-chromium-linux.png
diff --git a/...es-a-new-account-and-views-the-initial-balance-transaction-1-chromium-linux.png b/...es-a-new-account-and-views-the-initial-balance-transaction-1-chromium-linux.png
diff --git a/...es-a-new-account-and-views-the-initial-balance-transaction-2-chromium-linux.png b/...es-a-new-account-and-views-the-initial-balance-transaction-2-chromium-linux.png
diff --git a/...tion-available-funds-overspent-budgeted-and-for-next-month-1-chromium-linux.png b/...tion-available-funds-overspent-budgeted-and-for-next-month-1-chromium-linux.png
diff --git a/...tion-available-funds-overspent-budgeted-and-for-next-month-2-chromium-linux.png b/...tion-available-funds-overspent-budgeted-and-for-next-month-2-chromium-linux.png
diff --git a/...est.js-snapshots/Budget-transfer-funds-to-another-category-1-chromium-linux.png b/...est.js-snapshots/Budget-transfer-funds-to-another-category-1-chromium-linux.png
diff --git a/...est.js-snapshots/Budget-transfer-funds-to-another-category-2-chromium-linux.png b/...est.js-snapshots/Budget-transfer-funds-to-another-category-2-chromium-linux.png
diff --git a/packages/desktop-client/e2e/mobile.test.js b/packages/desktop-client/e2e/mobile.test.js
@@ -49,7 +49,7 @@ test.describe('Mobile', () => {
   test('opens the accounts page and asserts on balances', async () => {
     const accountsPage = await navigation.goToAccountsPage();
 
-    const account = await accountsPage.getNthAccount(0);
+    const account = await accountsPage.getNthAccount(1);
 
     await expect(account.name).toHaveText('Ally Savings');
     await expect(account.balance).toHaveText('7,653.00');
@@ -58,7 +58,7 @@ test.describe('Mobile', () => {
 
   test('opens individual account page and checks that filtering is working', async () => {
     const accountsPage = await navigation.goToAccountsPage();
-    const accountPage = await accountsPage.openNthAccount(1);
+    const accountPage = await accountsPage.openNthAccount(0);
 
     await expect(accountPage.heading).toHaveText('Bank of America');
     expect(await accountPage.getBalance()).toBeGreaterThan(0);

diff --git a/...ots/Mobile-opens-the-accounts-page-and-asserts-on-balances-1-chromium-linux.png b/...ots/Mobile-opens-the-accounts-page-and-asserts-on-balances-1-chromium-linux.png
diff --git a/...ots/Mobile-opens-the-accounts-page-and-asserts-on-balances-2-chromium-linux.png b/...ots/Mobile-opens-the-accounts-page-and-asserts-on-balances-2-chromium-linux.png
diff --git a/...snapshots/Reports-loads-cash-flow-graph-and-checks-visuals-1-chromium-linux.png b/...snapshots/Reports-loads-cash-flow-graph-and-checks-visuals-1-chromium-linux.png
diff --git a/...snapshots/Reports-loads-cash-flow-graph-and-checks-visuals-2-chromium-linux.png b/...snapshots/Reports-loads-cash-flow-graph-and-checks-visuals-2-chromium-linux.png
diff --git a/...js-snapshots/Reports-loads-net-worth-and-cash-flow-reports-1-chromium-linux.png b/...js-snapshots/Reports-loads-net-worth-and-cash-flow-reports-1-chromium-linux.png
diff --git a/...js-snapshots/Reports-loads-net-worth-and-cash-flow-reports-2-chromium-linux.png b/...js-snapshots/Reports-loads-net-worth-and-cash-flow-reports-2-chromium-linux.png
diff --git a/...snapshots/Reports-loads-net-worth-graph-and-checks-visuals-1-chromium-linux.png b/...snapshots/Reports-loads-net-worth-graph-and-checks-visuals-1-chromium-linux.png
diff --git a/...snapshots/Reports-loads-net-worth-graph-and-checks-visuals-2-chromium-linux.png b/...snapshots/Reports-loads-net-worth-graph-and-checks-visuals-2-chromium-linux.png
diff --git a/.../e2e/rules.test.js-snapshots/Rules-checks-the-page-visuals-1-chromium-linux.png b/.../e2e/rules.test.js-snapshots/Rules-checks-the-page-visuals-1-chromium-linux.png
diff --git a/.../e2e/rules.test.js-snapshots/Rules-checks-the-page-visuals-2-chromium-linux.png b/.../e2e/rules.test.js-snapshots/Rules-checks-the-page-visuals-2-chromium-linux.png
diff --git a/...e-and-makes-sure-it-is-applied-when-creating-a-transaction-1-chromium-linux.png b/...e-and-makes-sure-it-is-applied-when-creating-a-transaction-1-chromium-linux.png
diff --git a/...e-and-makes-sure-it-is-applied-when-creating-a-transaction-2-chromium-linux.png b/...e-and-makes-sure-it-is-applied-when-creating-a-transaction-2-chromium-linux.png
diff --git a/...e-and-makes-sure-it-is-applied-when-creating-a-transaction-3-chromium-linux.png b/...e-and-makes-sure-it-is-applied-when-creating-a-transaction-3-chromium-linux.png
diff --git a/...e-and-makes-sure-it-is-applied-when-creating-a-transaction-4-chromium-linux.png b/...e-and-makes-sure-it-is-applied-when-creating-a-transaction-4-chromium-linux.png
diff --git a/...edules.test.js-snapshots/Schedules-checks-the-page-visuals-1-chromium-linux.png b/...edules.test.js-snapshots/Schedules-checks-the-page-visuals-1-chromium-linux.png
diff --git a/...edules.test.js-snapshots/Schedules-checks-the-page-visuals-2-chromium-linux.png b/...edules.test.js-snapshots/Schedules-checks-the-page-visuals-2-chromium-linux.png
diff --git a/...-new-schedule-posts-the-transaction-and-later-completes-it-1-chromium-linux.png b/...-new-schedule-posts-the-transaction-and-later-completes-it-1-chromium-linux.png
diff --git a/...-new-schedule-posts-the-transaction-and-later-completes-it-2-chromium-linux.png b/...-new-schedule-posts-the-transaction-and-later-completes-it-2-chromium-linux.png
diff --git a/...-new-schedule-posts-the-transaction-and-later-completes-it-3-chromium-linux.png b/...-new-schedule-posts-the-transaction-and-later-completes-it-3-chromium-linux.png
diff --git a/...-new-schedule-posts-the-transaction-and-later-completes-it-4-chromium-linux.png b/...-new-schedule-posts-the-transaction-and-later-completes-it-4-chromium-linux.png
diff --git a/...-new-schedule-posts-the-transaction-and-later-completes-it-5-chromium-linux.png b/...-new-schedule-posts-the-transaction-and-later-completes-it-5-chromium-linux.png
diff --git a/...-new-schedule-posts-the-transaction-and-later-completes-it-6-chromium-linux.png b/...-new-schedule-posts-the-transaction-and-later-completes-it-6-chromium-linux.png
diff --git a/...-new-schedule-posts-the-transaction-and-later-completes-it-7-chromium-linux.png b/...-new-schedule-posts-the-transaction-and-later-completes-it-7-chromium-linux.png
diff --git a/...-new-schedule-posts-the-transaction-and-later-completes-it-8-chromium-linux.png b/...-new-schedule-posts-the-transaction-and-later-completes-it-8-chromium-linux.png
diff --git a/...ettings.test.js-snapshots/Settings-checks-the-page-visuals-1-chromium-linux.png b/...ettings.test.js-snapshots/Settings-checks-the-page-visuals-1-chromium-linux.png
diff --git a/...ettings.test.js-snapshots/Settings-checks-the-page-visuals-2-chromium-linux.png b/...ettings.test.js-snapshots/Settings-checks-the-page-visuals-2-chromium-linux.png
diff --git a/...ons.test.js-snapshots/Transactions-checks-the-page-visuals-1-chromium-linux.png b/...ons.test.js-snapshots/Transactions-checks-the-page-visuals-1-chromium-linux.png
diff --git a/...ons.test.js-snapshots/Transactions-checks-the-page-visuals-2-chromium-linux.png b/...ons.test.js-snapshots/Transactions-checks-the-page-visuals-2-chromium-linux.png
diff --git a/...js-snapshots/Transactions-creates-a-split-test-transaction-1-chromium-linux.png b/...js-snapshots/Transactions-creates-a-split-test-transaction-1-chromium-linux.png
diff --git a/...js-snapshots/Transactions-creates-a-split-test-transaction-2-chromium-linux.png b/...js-snapshots/Transactions-creates-a-split-test-transaction-2-chromium-linux.png
diff --git a/....test.js-snapshots/Transactions-creates-a-test-transaction-1-chromium-linux.png b/....test.js-snapshots/Transactions-creates-a-test-transaction-1-chromium-linux.png
diff --git a/....test.js-snapshots/Transactions-creates-a-test-transaction-2-chromium-linux.png b/....test.js-snapshots/Transactions-creates-a-test-transaction-2-chromium-linux.png
diff --git a/...js-snapshots/Transactions-filters-transactions-by-category-5-chromium-linux.png b/...js-snapshots/Transactions-filters-transactions-by-category-5-chromium-linux.png
diff --git a/...js-snapshots/Transactions-filters-transactions-by-category-6-chromium-linux.png b/...js-snapshots/Transactions-filters-transactions-by-category-6-chromium-linux.png
diff --git a/...est.js-snapshots/Transactions-filters-transactions-by-date-5-chromium-linux.png b/...est.js-snapshots/Transactions-filters-transactions-by-date-5-chromium-linux.png
diff --git a/...est.js-snapshots/Transactions-filters-transactions-by-date-6-chromium-linux.png b/...est.js-snapshots/Transactions-filters-transactions-by-date-6-chromium-linux.png
diff --git a/packages/loot-core/src/mocks/budget.ts b/packages/loot-core/src/mocks/budget.ts
@@ -589,13 +589,12 @@ export async function createTestBudget(handlers: Handlers) {
     { name: 'House Asset', offBudget: true },
     { name: 'Roth IRA', offBudget: true },
   ];
-  await runMutator(() =>
-    batchMessages(async () => {
-      for (const account of accounts) {
-        account.id = await handlers['account-create'](account);
-      }
-    }),
-  );
+
+  await runMutator(async () => {
+    for (const account of accounts) {
+      account.id = await handlers['account-create'](account);
+    }
+  });
 
   const payees: Array<MockPayeeEntity> = [
     { name: 'Starting Balance' },

diff --git a/upcoming-release-notes/2279.md b/upcoming-release-notes/2279.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [youngcw]
+---
+
+Fix same account sort_order when creating a demo budget