Add Upcoming length adjustment feature flag (#3651)

* feature flag created * feature flag implemented * feature toggle setting added * added release notes * Update packages/desktop-client/src/components/settings/Experimental.tsx Co-authored-by: Matiss Janis Aboltins <[email protected]> * vrt * vrt --------- Co-authored-by: Matiss Janis Aboltins <[email protected]>
actualbudget · Oct 18, 2024 · 3f31d19 · 3f31d19
1 parent 225c939
commit 3f31d19
Show file tree

Hide file tree

Showing 20 changed files with 20 additions and 1 deletion.
diff --git a/...edules.test.js-snapshots/Schedules-checks-the-page-visuals-1-chromium-linux.png b/...edules.test.js-snapshots/Schedules-checks-the-page-visuals-1-chromium-linux.png
diff --git a/...edules.test.js-snapshots/Schedules-checks-the-page-visuals-2-chromium-linux.png b/...edules.test.js-snapshots/Schedules-checks-the-page-visuals-2-chromium-linux.png
diff --git a/...edules.test.js-snapshots/Schedules-checks-the-page-visuals-3-chromium-linux.png b/...edules.test.js-snapshots/Schedules-checks-the-page-visuals-3-chromium-linux.png
diff --git a/...-new-schedule-posts-the-transaction-and-later-completes-it-1-chromium-linux.png b/...-new-schedule-posts-the-transaction-and-later-completes-it-1-chromium-linux.png
diff --git a/...new-schedule-posts-the-transaction-and-later-completes-it-10-chromium-linux.png b/...new-schedule-posts-the-transaction-and-later-completes-it-10-chromium-linux.png
diff --git a/...new-schedule-posts-the-transaction-and-later-completes-it-11-chromium-linux.png b/...new-schedule-posts-the-transaction-and-later-completes-it-11-chromium-linux.png
diff --git a/...new-schedule-posts-the-transaction-and-later-completes-it-12-chromium-linux.png b/...new-schedule-posts-the-transaction-and-later-completes-it-12-chromium-linux.png
diff --git a/...-new-schedule-posts-the-transaction-and-later-completes-it-2-chromium-linux.png b/...-new-schedule-posts-the-transaction-and-later-completes-it-2-chromium-linux.png
diff --git a/...-new-schedule-posts-the-transaction-and-later-completes-it-3-chromium-linux.png b/...-new-schedule-posts-the-transaction-and-later-completes-it-3-chromium-linux.png
diff --git a/...-new-schedule-posts-the-transaction-and-later-completes-it-4-chromium-linux.png b/...-new-schedule-posts-the-transaction-and-later-completes-it-4-chromium-linux.png
diff --git a/...-new-schedule-posts-the-transaction-and-later-completes-it-5-chromium-linux.png b/...-new-schedule-posts-the-transaction-and-later-completes-it-5-chromium-linux.png
diff --git a/...-new-schedule-posts-the-transaction-and-later-completes-it-6-chromium-linux.png b/...-new-schedule-posts-the-transaction-and-later-completes-it-6-chromium-linux.png
diff --git a/...-new-schedule-posts-the-transaction-and-later-completes-it-7-chromium-linux.png b/...-new-schedule-posts-the-transaction-and-later-completes-it-7-chromium-linux.png
diff --git a/...-new-schedule-posts-the-transaction-and-later-completes-it-8-chromium-linux.png b/...-new-schedule-posts-the-transaction-and-later-completes-it-8-chromium-linux.png
diff --git a/...-new-schedule-posts-the-transaction-and-later-completes-it-9-chromium-linux.png b/...-new-schedule-posts-the-transaction-and-later-completes-it-9-chromium-linux.png
diff --git a/packages/desktop-client/src/components/settings/Experimental.tsx b/packages/desktop-client/src/components/settings/Experimental.tsx
@@ -116,6 +116,12 @@ export function ExperimentalFeatures() {
             >
               <Trans>Rule action templating</Trans>
             </FeatureToggle>
+            <FeatureToggle
+              flag="upcomingLengthAdjustment"
+              feedbackLink="https://github.com/actualbudget/actual/issues/3660"
+            >
+              <Trans>Scheduled transaction upcoming length adjustment</Trans>
+            </FeatureToggle>
           </View>
         ) : (
           <Link

diff --git a/packages/desktop-client/src/components/settings/Upcoming.tsx b/packages/desktop-client/src/components/settings/Upcoming.tsx
@@ -6,6 +6,7 @@ import { Column } from 'glamor/jsxstyle';
 
 import { type SyncedPrefs } from 'loot-core/types/prefs';
 
+import { useFeatureFlag } from '../../hooks/useFeatureFlag';
 import { useSyncedPref } from '../../hooks/useSyncedPref';
 import { type CSSProperties, theme } from '../../style';
 import { Button } from '../common/Button2';
@@ -38,9 +39,13 @@ export function UpcomingLengthSettings() {
     },
   };
 
+  const enabled = useFeatureFlag('upcomingLengthAdjustment');
+
   const location = useLocation();
   const [expanded, setExpanded] = useState(location.hash === '#upcomingLength');
 
+  if (!enabled) return null;
+
   return expanded ? (
     <Setting
       primaryAction={

diff --git a/packages/desktop-client/src/hooks/useFeatureFlag.ts b/packages/desktop-client/src/hooks/useFeatureFlag.ts
@@ -8,6 +8,7 @@ const DEFAULT_FEATURE_FLAG_STATE: Record<FeatureFlag, boolean> = {
   spendingReport: false,
   dashboards: false,
   actionTemplating: false,
+  upcomingLengthAdjustment: false,
 };
 
 export function useFeatureFlag(name: FeatureFlag): boolean {

diff --git a/packages/loot-core/src/types/prefs.d.ts b/packages/loot-core/src/types/prefs.d.ts
@@ -3,7 +3,8 @@ export type FeatureFlag =
   | 'reportBudget'
   | 'goalTemplatesEnabled'
   | 'spendingReport'
-  | 'actionTemplating';
+  | 'actionTemplating'
+  | 'upcomingLengthAdjustment';
 
 /**
  * Cross-device preferences. These sync across devices when they are changed.

diff --git a/upcoming-release-notes/3651.md b/upcoming-release-notes/3651.md
@@ -0,0 +1,6 @@
+---
+category: Maintenance
+authors: [ SamBobBarnes ]
+---
+
+Add feature flag for upcoming length adjustment setting.