Remove unused args

actualbudget · Nov 18, 2023 · 2ed0cc3 · 2ed0cc3
1 parent 855e727
commit 2ed0cc3
Show file tree

Hide file tree

Showing 76 changed files with 120 additions and 147 deletions.
diff --git a/packages/desktop-client/craco.config.ts b/packages/desktop-client/craco.config.ts
@@ -22,7 +22,7 @@ if (process.env.REVIEW_ID) {
 
 module.exports = {
   webpack: {
-    configure: (webpackConfig, { env, paths }) => {
+    configure: webpackConfig => {
       webpackConfig.mode =
         process.env.NODE_ENV === 'development' ? 'development' : 'production';
 
@@ -92,7 +92,7 @@ module.exports = {
       return webpackConfig;
     },
   },
-  devServer: (devServerConfig, { env, paths, proxy, allowedHost }) => {
+  devServer: devServerConfig => {
     devServerConfig.onBeforeSetupMiddleware = server => {
       chokidar
         .watch([

diff --git a/packages/desktop-client/src/browser-preload.browser.js b/packages/desktop-client/src/browser-preload.browser.js
@@ -51,7 +51,7 @@ global.Actual = {
     window.location.reload();
   },
 
-  openFileDialog: async ({ filters = [], properties }) => {
+  openFileDialog: async ({ filters = [] }) => {
     return new Promise(resolve => {
       let createdElement = false;
       // Attempt to reuse an already-created file input.
@@ -91,7 +91,7 @@ global.Actual = {
               .uploadFile(filename, ev.target.result)
               .then(() => resolve([filepath]));
           };
-          reader.onerror = function (ev) {
+          reader.onerror = function () {
             alert('Error reading file');
           };
         }
@@ -107,7 +107,7 @@ global.Actual = {
     });
   },
 
-  saveFile: (contents, defaultFilename, dialogTitle) => {
+  saveFile: (contents, defaultFilename) => {
     const temp = document.createElement('a');
     temp.style = 'display: none';
     temp.download = defaultFilename;
@@ -121,9 +121,9 @@ global.Actual = {
   openURLInBrowser: url => {
     window.open(url, '_blank');
   },
-  onEventFromMain: (type, handler) => {},
+  onEventFromMain: () => {},
   applyAppUpdate: () => {},
-  updateAppMenu: isBudgetOpen => {},
+  updateAppMenu: () => {},
 
   getServerSocket: async () => {
     return worker;

diff --git a/packages/desktop-client/src/components/FixedSizeList.js b/packages/desktop-client/src/components/FixedSizeList.js
@@ -8,7 +8,7 @@ import View from './common/View';
 
 const IS_SCROLLING_DEBOUNCE_INTERVAL = 150;
 
-const defaultItemKey = (index, data) => index;
+const defaultItemKey = index => index;
 
 function ResizeObserver({ onResize, children }) {
   let ref = useResizeObserver(onResize);
@@ -241,7 +241,7 @@ export default class FixedSizeList extends PureComponent {
     }
   };
 
-  onHeaderResize = rect => {
+  onHeaderResize = () => {
     // this.setState({ headerHeight: rect.height });
   };
 
@@ -268,7 +268,7 @@ export default class FixedSizeList extends PureComponent {
   }
 
   getItemOffset = index => index * this.props.itemSize;
-  getItemSize = index => this.props.itemSize;
+  getItemSize = () => this.props.itemSize;
   getEstimatedTotalSize = () => this.props.itemSize * this.props.itemCount;
 
   getOffsetForIndexAndAlignment = (index, align, scrollOffset) => {

diff --git a/packages/desktop-client/src/components/ManageRules.tsx b/packages/desktop-client/src/components/ManageRules.tsx
@@ -236,7 +236,7 @@ function ManageRulesContent({
         onSave: async newRule => {
           let newRules = await loadRules();
 
-          setRules(rules => {
+          setRules(() => {
             let newIdx = newRules.findIndex(rule => rule.id === newRule.id);
             return newRules.slice(0, newIdx + 75);
           });

diff --git a/packages/desktop-client/src/components/accounts/Account.js b/packages/desktop-client/src/components/accounts/Account.js
@@ -227,7 +227,7 @@ class AccountInternal extends PureComponent {
       }
     };
 
-    let onUndo = async ({ tables, messages, undoTag }) => {
+    let onUndo = async ({ tables, messages }) => {
       await maybeRefetch(tables);
 
       // If all the messages are dealing with transactions, find the
@@ -514,7 +514,7 @@ class AccountInternal extends PureComponent {
           });
         }
       },
-      mappedData => {
+      () => {
         return data;
       },
     );

diff --git a/packages/desktop-client/src/components/accounts/MobileAccount.js b/packages/desktop-client/src/components/accounts/MobileAccount.js
@@ -40,7 +40,7 @@ const getSchedulesTransform = memoizeOne((id, hasSearch) => {
   };
 });
 
-function PreviewTransactions({ accountId, children }) {
+function PreviewTransactions({ children }) {
   let scheduleData = useCachedSchedules();
 
   if (scheduleData == null) {

diff --git a/packages/desktop-client/src/components/accounts/MobileAccounts.js b/packages/desktop-client/src/components/accounts/MobileAccounts.js
@@ -124,7 +124,7 @@ function AccountCard({ account, updated, getBalanceQuery, onSelect }) {
   );
 }
 
-function EmptyMessage({ onAdd }) {
+function EmptyMessage() {
   return (
     <View style={{ flex: 1, padding: 30 }}>
       <Text style={styles.text}>

diff --git a/packages/desktop-client/src/components/budget/MobileBudget.js b/packages/desktop-client/src/components/budget/MobileBudget.js
@@ -353,7 +353,7 @@ class Budget extends Component {
 
     return (
       <SyncRefresh onSync={this.sync}>
-        {({ refreshing, onRefresh }) => (
+        {({ onRefresh }) => (
           <BudgetTable
             // This key forces the whole table rerender when the number
             // format changes

diff --git a/packages/desktop-client/src/components/budget/MobileBudgetTable.js b/packages/desktop-client/src/components/budget/MobileBudgetTable.js
@@ -132,7 +132,7 @@ function BudgetCell({
     });
   }
 
-  function onAmountClick(e) {
+  function onAmountClick() {
     onEdit?.(categoryId);
   }
 

diff --git a/packages/desktop-client/src/components/budget/SidebarCategory.tsx b/packages/desktop-client/src/components/budget/SidebarCategory.tsx
@@ -146,7 +146,7 @@ function SidebarCategory({
     >
       <InputCell
         value={category.name}
-        formatter={value => displayed}
+        formatter={() => displayed}
         width="flex"
         exposed={editing || temporary}
         onUpdate={value => {

diff --git a/packages/desktop-client/src/components/budget/SidebarGroup.tsx b/packages/desktop-client/src/components/budget/SidebarGroup.tsx
@@ -43,7 +43,6 @@ function SidebarGroup({
   dragPreview,
   innerRef,
   style,
-  borderColor = theme.tableBorder,
   onEdit,
   onSave,
   onDelete,
@@ -62,7 +61,7 @@ function SidebarGroup({
         userSelect: 'none',
         WebkitUserSelect: 'none',
       }}
-      onClick={e => {
+      onClick={() => {
         onToggleCollapse(group.id);
       }}
     >
@@ -168,7 +167,7 @@ function SidebarGroup({
     >
       <InputCell
         value={group.name}
-        formatter={value => displayed}
+        formatter={() => displayed}
         width="flex"
         exposed={editing}
         onUpdate={value => {

diff --git a/packages/desktop-client/src/components/budget/index.tsx b/packages/desktop-client/src/components/budget/index.tsx
@@ -506,7 +506,7 @@ const RolloverBudgetSummary = memo<{ month: string }>(props => {
   );
 });
 
-export default function BudgetWrapper(props) {
+export default function BudgetWrapper() {
   let startMonth = useSelector(state => state.prefs.local['budget.startMonth']);
   let collapsedPrefs = useSelector(
     state => state.prefs.local['budget.collapsed'],

diff --git a/packages/desktop-client/src/components/budget/report/components.tsx b/packages/desktop-client/src/components/budget/report/components.tsx
@@ -163,7 +163,7 @@ function BalanceTooltip({
       onClose={tooltip.close}
     >
       <Menu
-        onMenuSelect={type => {
+        onMenuSelect={() => {
           onBudgetAction(monthIndex, 'carryover', {
             category: categoryId,
             flag: !carryover,

diff --git a/packages/desktop-client/src/components/budget/rollover/BudgetSummary.tsx b/packages/desktop-client/src/components/budget/rollover/BudgetSummary.tsx
@@ -274,7 +274,7 @@ export function BudgetSummary({
   } = useRollover();
 
   let [menuOpen, setMenuOpen] = useState(false);
-  function onMenuOpen(e) {
+  function onMenuOpen() {
     setMenuOpen(true);
   }
 

diff --git a/packages/desktop-client/src/components/budget/rollover/CoverTooltip.tsx b/packages/desktop-client/src/components/budget/rollover/CoverTooltip.tsx
@@ -47,7 +47,7 @@ export default function CoverTooltip({
             categoryGroups={categoryGroups}
             value={null}
             openOnFocus={true}
-            onUpdate={id => {}}
+            onUpdate={() => {}}
             onSelect={id => setCategory(id)}
             inputProps={{
               inputRef: node,

diff --git a/packages/desktop-client/src/components/budget/rollover/TransferTooltip.tsx b/packages/desktop-client/src/components/budget/rollover/TransferTooltip.tsx
@@ -98,7 +98,7 @@ export default function TransferTooltip({
         categoryGroups={categoryGroups}
         value={null}
         openOnFocus={true}
-        onUpdate={id => {}}
+        onUpdate={() => {}}
         onSelect={id => setCategory(id)}
         inputProps={{ onEnter: submit, placeholder: '(none)' }}
       />

diff --git a/packages/desktop-client/src/components/common/Menu.tsx b/packages/desktop-client/src/components/common/Menu.tsx
@@ -158,7 +158,7 @@ export default function Menu({
             }}
             onMouseEnter={() => setHoveredIndex(idx)}
             onMouseLeave={() => setHoveredIndex(null)}
-            onClick={e =>
+            onClick={() =>
               !item.disabled && onMenuSelect && onMenuSelect(item.name)
             }
           >

diff --git a/packages/desktop-client/src/components/mobile/MobileAmountInput.js b/packages/desktop-client/src/components/mobile/MobileAmountInput.js
@@ -48,7 +48,7 @@ class AmountInput extends PureComponent {
     }
   }
 
-  componentDidUpdate(prevProps, prevState) {
+  componentDidUpdate(prevProps, _prevState) {
     if (!prevProps.focused && this.props.focused) {
       this.focus();
     }

diff --git a/packages/desktop-client/src/components/modals/EditRule.js b/packages/desktop-client/src/components/modals/EditRule.js
@@ -122,7 +122,7 @@ export function OpSelect({
   );
 }
 
-function EditorButtons({ onAdd, onDelete, style }) {
+function EditorButtons({ onAdd, onDelete }) {
   return (
     <>
       {onDelete && (
@@ -309,7 +309,7 @@ let actionFields = [
   'date',
   'amount',
 ].map(field => [field, mapField(field)]);
-function ActionEditor({ ops, action, editorStyle, onChange, onDelete, onAdd }) {
+function ActionEditor({ action, editorStyle, onChange, onDelete, onAdd }) {
   let { field, op, value, type, error, inputKey = 'initial' } = action;
 
   return (

diff --git a/packages/desktop-client/src/components/modals/ImportTransactions.js b/packages/desktop-client/src/components/modals/ImportTransactions.js
@@ -133,7 +133,7 @@ function getFileType(filepath) {
   return rawType;
 }
 
-function ParsedDate({ parseDateFormat, showParsed, dateFormat, date }) {
+function ParsedDate({ parseDateFormat, dateFormat, date }) {
   let parsed =
     date &&
     formatDate(
@@ -185,29 +185,29 @@ function getInitialMappings(transactions) {
   }
 
   let dateField = key(
-    fields.find(([name, value]) => name.toLowerCase().includes('date')) ||
-      fields.find(([name, value]) => value.match(/^\d+[-/]\d+[-/]\d+$/)),
+    fields.find(([name]) => name.toLowerCase().includes('date')) ||
+      fields.find(([value]) => value.match(/^\d+[-/]\d+[-/]\d+$/)),
   );
 
   let amountField = key(
-    fields.find(([name, value]) => name.toLowerCase().includes('amount')) ||
-      fields.find(([name, value]) => value.match(/^-?[.,\d]+$/)),
+    fields.find(([name]) => name.toLowerCase().includes('amount')) ||
+      fields.find(([value]) => value.match(/^-?[.,\d]+$/)),
   );
 
   let payeeField = key(
-    fields.find(([name, value]) => name !== dateField && name !== amountField),
+    fields.find(([name]) => name !== dateField && name !== amountField),
   );
 
   let notesField = key(
     fields.find(
-      ([name, value]) =>
+      ([name]) =>
         name !== dateField && name !== amountField && name !== payeeField,
     ),
   );
 
   let inOutField = key(
     fields.find(
-      ([name, value]) =>
+      ([name]) =>
         name !== dateField &&
         name !== amountField &&
         name !== payeeField &&
@@ -974,7 +974,7 @@ export default function ImportTransactions({ modalProps, options }) {
                 </View>
               );
             }}
-            renderItem={({ key, style, item, editing, focusedField }) => (
+            renderItem={({ key, style, item }) => (
               <View key={key} style={style}>
                 <Transaction
                   transaction={item}

diff --git a/packages/desktop-client/src/components/modals/SingleInput.tsx b/packages/desktop-client/src/components/modals/SingleInput.tsx
@@ -72,7 +72,7 @@ function SingleInput({
               paddingBottom: 15,
             }}
           >
-            <Button onPointerUp={e => _onSubmit(value)}>{buttonText}</Button>
+            <Button onPointerUp={() => _onSubmit(value)}>{buttonText}</Button>
           </View>
         </>
       )}

diff --git a/packages/desktop-client/src/components/payees/ManagePayeesWithData.js b/packages/desktop-client/src/components/payees/ManagePayeesWithData.js
@@ -63,7 +63,7 @@ export default function ManagePayeesWithData({ initialSelectedIds }) {
     };
   }, []);
 
-  async function onUndo({ tables, messages, meta, url }, scroll = false) {
+  async function onUndo({ tables, messages, meta }, _scroll = false) {
     if (!tables.includes('payees') && !tables.includes('payee_mapping')) {
       return;
     }

diff --git a/packages/desktop-client/src/components/payees/index.js b/packages/desktop-client/src/components/payees/index.js
@@ -170,7 +170,6 @@ const PayeeTable = forwardRef(
       navigator,
       categoryGroups,
       highlightedRows,
-      ruleActions,
       onUpdate,
       onViewRules,
       onCreateRule,

diff --git a/packages/desktop-client/src/components/reports/CategorySelector.tsx b/packages/desktop-client/src/components/reports/CategorySelector.tsx
@@ -80,7 +80,7 @@ export default function CategorySelector({
                   <Checkbox
                     id={`form_${categoryGroup.id}`}
                     checked={allCategoriesInGroupSelected}
-                    onChange={e => {
+                    onChange={() => {
                       const selectedCategoriesExcludingGroupCategories =
                         selectedCategories.filter(
                           selectedCategory =>
@@ -118,7 +118,7 @@ export default function CategorySelector({
                       paddingLeft: 10,
                     }}
                   >
-                    {categoryGroup.categories.map((category, index) => {
+                    {categoryGroup.categories.map(category => {
                       const isChecked = selectedCategories.some(
                         selectedCategory => selectedCategory.id === category.id,
                       );
@@ -135,7 +135,7 @@ export default function CategorySelector({
                           <Checkbox
                             id={`form_${category.id}`}
                             checked={isChecked}
-                            onChange={e => {
+                            onChange={() => {
                               if (isChecked) {
                                 setSelectedCategories(
                                   selectedCategories.filter(

diff --git a/packages/desktop-client/src/components/reports/Header.js b/packages/desktop-client/src/components/reports/Header.js
@@ -63,7 +63,6 @@ function Header({
   onDeleteFilter,
   onCondOpChange,
   headerPrefixItems,
-  selectGraph,
 }) {
   let location = useLocation();
   let path = location.pathname;

diff --git a/packages/desktop-client/src/components/reports/ReportSidebar.js b/packages/desktop-client/src/components/reports/ReportSidebar.js
@@ -54,7 +54,6 @@ export function ReportSidebar({
   allMonths,
   graphType,
   setGraphType,
-  setViewLegend,
   typeDisabled,
   setTypeDisabled,
   groupBy,

diff --git a/packages/desktop-client/src/components/reports/ReportSummary.js b/packages/desktop-client/src/components/reports/ReportSummary.js
@@ -136,7 +136,7 @@ export function ReportSummary({
   );
 }
 
-export function ReportLegend({ data, legend, groupBy }) {
+export function ReportLegend({ legend, groupBy }) {
   return (
     <View
       style={{
-Original file line number
+Diff line change
@@ Expand Up / @@ -132,7 +132,7 @@ function BudgetCell({ @@
         });
       }
-      function onAmountClick(e) {
+      function onAmountClick() {
         onEdit?.(categoryId);
       }
@@ Expand Down @@