fix: don't clobber server pathname (#3815)

* fix: don't clobber server pathname The provided server URL may already include a pathname, so all further segments need to be appended. This also more closely matches the name `joinURL`. * add release notes * use `fs.join` to avoid double slashes
actualbudget · Nov 12, 2024 · 2cb668a · 2cb668a
1 parent 3cefd98
commit 2cb668a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/packages/loot-core/src/server/server-config.ts b/packages/loot-core/src/server/server-config.ts
@@ -12,7 +12,7 @@ let config: ServerConfig | null = null;
 
 function joinURL(base: string | URL, ...paths: string[]): string {
   const url = new URL(base);
-  url.pathname = fs.join(...paths);
+  url.pathname = fs.join(url.pathname, ...paths);
   return url.toString();
 }
 

diff --git a/upcoming-release-notes/3815.md b/upcoming-release-notes/3815.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [joshyrobot]
+---
+
+Allow server URLs to contain pathnames.