🔧 Prevent sidebar from saving to metadata until resize is complete (#…

…3393) * prevent sidebar from saving to metadata until resize is complete * add release notes
actualbudget · Sep 8, 2024 · 008a8a7 · 008a8a7
1 parent c466189
commit 008a8a7
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 4 deletions.
diff --git a/packages/desktop-client/src/components/sidebar/Sidebar.tsx b/packages/desktop-client/src/components/sidebar/Sidebar.tsx
@@ -50,15 +50,26 @@ export function Sidebar() {
   const [isFloating = false, setFloatingSidebarPref] =
     useGlobalPref('floatingSidebar');
 
-  const [_sidebarWidth, setSidebarWidth] = useLocalPref('sidebarWidth');
+  const [sidebarWidthLocalPref, setSidebarWidthLocalPref] =
+    useLocalPref('sidebarWidth');
   const DEFAULT_SIDEBAR_WIDTH = 240;
   const MAX_SIDEBAR_WIDTH = width / 3;
   const MIN_SIDEBAR_WIDTH = 200;
-  const sidebarWidth = Math.min(
-    MAX_SIDEBAR_WIDTH,
-    Math.max(MIN_SIDEBAR_WIDTH, _sidebarWidth || DEFAULT_SIDEBAR_WIDTH),
+
+  const [sidebarWidth, setSidebarWidth] = useState(
+    Math.min(
+      MAX_SIDEBAR_WIDTH,
+      Math.max(
+        MIN_SIDEBAR_WIDTH,
+        sidebarWidthLocalPref || DEFAULT_SIDEBAR_WIDTH,
+      ),
+    ),
   );
 
+  const onResizeStop = () => {
+    setSidebarWidthLocalPref(sidebarWidth);
+  };
+
   async function onReorder(
     id: string,
     dropPos: 'top' | 'bottom',
@@ -95,6 +106,7 @@ export function Sidebar() {
         width: sidebarWidth,
         height: '100%',
       }}
+      onResizeStop={onResizeStop}
       maxWidth={MAX_SIDEBAR_WIDTH}
       minWidth={MIN_SIDEBAR_WIDTH}
       enable={{

diff --git a/upcoming-release-notes/3393.md b/upcoming-release-notes/3393.md
@@ -0,0 +1,6 @@
+---
+category: Maintenance
+authors: [MikesGlitch]
+---
+
+Prevent sidebar from saving to metadata.json unnecessarily