Skip to content
Test

[Maintenance] Convert ExpenseGroup, ExpenseCategory, IncomeCategory components to Typescript. #3362

Sign in to view logs

[Maintenance] Convert ExpenseGroup, ExpenseCategory, IncomeCategory components to Typescript.

[Maintenance] Convert ExpenseGroup, ExpenseCategory, IncomeCategory components to Typescript. #3362

Triggered via pull request November 11, 2023 20:24
@MikesGlitchMikesGlitch
synchronize #1897
MikesGlitch:maintenance/typescript-components
Status Failure
Total duration 1m 45s
Artifacts –

check.yml

on: pull_request
lint
1m 19s
lint
typecheck
35s
typecheck
test
1m 35s
test
migrations
12s
migrations
Fit to window
Zoom out
Zoom in

Annotations

1 error and 10 warnings
lint
Process completed with exit code 1.
lint: packages/desktop-client/src/components/budget/IncomeCategory.tsx#L1
Import "ComponentProps" is only used as types
lint: packages/desktop-client/src/components/budget/IncomeCategory.tsx#L3
Imports "OnDragChangeCallback" and "OnDropCallback" are only used as types
lint: packages/desktop-client/src/components/budget/IncomeCategory.tsx#L3
Replace `·useDraggable,·useDroppable,·DropHighlight,·OnDragChangeCallback,·OnDropCallback·` with `⏎··useDraggable,⏎··useDroppable,⏎··DropHighlight,⏎··OnDragChangeCallback,⏎··OnDropCallback,⏎`
lint: packages/desktop-client/src/components/budget/IncomeCategory.tsx#L7
There should be at least one empty line between import groups
lint: packages/desktop-client/src/components/budget/IncomeCategory.tsx#L8
All imports in the declaration are only used as types. Use `import type`
lint: packages/desktop-client/src/components/budget/IncomeCategory.tsx#L8
`loot-core/src/types/models` import should occur before import of `../sort`
lint: packages/desktop-client/src/components/budget/IncomeCategory.tsx#L14
Replace `"component"` with `'component'`
lint: packages/desktop-client/src/components/budget/IncomeCategory.tsx#L15
Replace `"onEditName"` with `'onEditName'`
lint: packages/desktop-client/src/components/budget/IncomeCategory.tsx#L17
Replace `"onSave"` with `'onSave'`
lint: packages/desktop-client/src/components/budget/IncomeCategory.tsx#L18
Replace `"onDelete"` with `'onDelete'`