Update easybank-bawaatww.js to change accessValidForDays: 179 from 180

[clutwo]

Fix linking accounts for easybank Austria:

Fixes #446

[coderabbitai]

Walkthrough

The changes in the pull request focus on the src/app-gocardless/banks/easybank-bawaatww.js file. The primary modification involves updating the accessValidForDays property, changing its value from 180 to 179. Other functionalities within the file remain unchanged, including the sorting logic in the sortTransactions method, which continues to sort transactions based on value, booking dates, and transaction IDs. The normalizeTransaction method also retains its original logic for processing transaction dates and formatting payee names. Furthermore, the extractPayeeName function is unaffected, still utilizing a regular expression to extract the payee name from the remittanceInformationStructured field. The main takeaway from this update is the adjustment of the accessValidForDays value.

Suggested labels

:sparkles: Merged

Suggested reviewers

• matt-fidd

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between c9e6d78 and ebdec91.

⛔ Files ignored due to path filters (1)

• upcoming-release-notes/486.md is excluded by !**/*.md

📒 Files selected for processing (1)

• src/app-gocardless/banks/easybank-bawaatww.js (1 hunks)

🔇 Additional comments (1)

src/app-gocardless/banks/easybank-bawaatww.js (1)

13-13: LGTM! Consider adding a comment explaining the 179-day requirement.

The change from 180 to 179 days appears to be a compliance adjustment for easybank Austria's API requirements.

Consider adding a comment explaining why specifically 179 days was chosen, for future maintainability:

+  // easybank Austria requires access tokens to be refreshed before 180 days
  accessValidForDays: 179,

Let's verify if this value is documented in the repository:

✅ Verification successful

Let me gather more information about this change by searching for any related code or documentation.

---

Based on the search results, I can now generate a final response:

The change to 179 days is specific to easybank Austria and appears to be a deliberate adjustment

The codebase shows that most other banks are configured with accessValidForDays: 180, which aligns with EEA requirements as documented in the integration-bank.js comments:

"EEA need to allow at least 180 days now..."

Setting it to 179 days for easybank Austria is a prudent approach to ensure token refresh happens before the 180-day limit is reached, preventing any potential token expiration issues.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for any documentation about easybank access token validity
rg -i "easybank.*token|token.*easybank|180|179.*day" --type md

Length of output: 179

---

Script:

#!/bin/bash
# Search for any mentions of easybank and token validity across all files
rg -i "easybank.*token|token.*easybank|180|179.*day" -A 2 -B 2

# Also check for any comments or documentation in the bank integration file
cat src/app-gocardless/banks/easybank-bawaatww.js

Length of output: 16758

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[matt-fidd]

LGTM thank you!