Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom handler for the German bank Rheinhessen Sparkasse to the GoCardless app #454
Add custom handler for the German bank Rheinhessen Sparkasse to the GoCardless app #454
Changes from 10 commits
e0c4a30
9ee4421
be81684
5b53bf7
7ce4c90
42b6053
2a99577
ca314e2
ebc0e5c
94f67b6
5a84b18
87b2080
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unused imports to improve code cleanliness
The static analysis tool correctly identified that
printIban
andamountToInteger
are imported but not used in this file. To keep the code clean and prevent potential confusion, it's recommended to remove unused imports.Apply this diff to remove the unused imports:
import Fallback from './integration-bank.js'; -import { printIban, amountToInteger } from '../utils.js'; import { formatPayeeName } from '../../util/payee-name.js';
📝 Committable suggestion
🧰 Tools
GitHub Check: lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactor to avoid mutating the transaction object
The
normalizeTransaction
function is mostly well-implemented, but there's an issue with directly mutating thetransaction
object. This was correctly identified in a previous review comment. Let's address this to improve the function's immutability.Apply this diff to refactor the function:
This change ensures that we're not modifying the original
transaction
object, which aligns better with immutability principles and prevents potential side effects.📝 Committable suggestion