-
-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SimpleFin #296
Merged
Merged
SimpleFin #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
joel-jeremy
reviewed
Jan 12, 2024
joel-jeremy
reviewed
Jan 12, 2024
joel-jeremy
reviewed
Jan 12, 2024
@joel-jeremy @youngcw @MatissJanis this PR is ready as well now. |
joel-jeremy
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
trafico-bot
bot
added
✅ Approved
Pull Request has been approved and can be merged
and removed
🔍 Ready for Review
labels
Jan 19, 2024
trafico-bot
bot
added
✨ Merged
Pull Request has been merged successfully
and removed
✅ Approved
Pull Request has been approved and can be merged
labels
Jan 20, 2024
MMichotte
pushed a commit
to MMichotte/actual-server
that referenced
this pull request
Sep 9, 2024
* Initial support for SimpleFin. * Added release notes and lint cleanup. * Changed some notes for better context. * Fixed logic. * Changes per requests on PR. * More cleanup of null checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SimpleFin can now be configured in the UI and sync transactions, somewhat adjacent to this issue.
There is also an app PR for these changes: actualbudget/actual#2188
General discussion should be held on the app PR linked above.