Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store migrations statestore in datadir #289

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Store migrations statestore in datadir #289

merged 2 commits into from
Dec 5, 2023

Conversation

bjw-s
Copy link
Contributor

@bjw-s bjw-s commented Dec 4, 2023 •
edited
Loading

This PR makes it so the .migrations file gets stored in the dataDir instead of the application root. This should fix #288 and actualbudget/actual#2011.

@bjw-s bjw-s changed the title Put migrations statestore in datadir Store migrations statestore in datadir Dec 4, 2023
@bjw-s bjw-s marked this pull request as ready for review December 4, 2023 09:56
@bjw-s bjw-s mentioned this pull request Dec 4, 2023
Closed
1 task
MatissJanis
MatissJanis approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@MatissJanis MatissJanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review labels Dec 5, 2023
@MatissJanis MatissJanis merged commit f93893e into actualbudget:master Dec 5, 2023
6 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved Pull Request has been approved and can be merged labels Dec 5, 2023
@bjw-s-safe-settings bjw-s-safe-settings bot deleted the master branch December 7, 2023 09:14
MMichotte pushed a commit to MMichotte/actual-server that referenced this pull request Sep 9, 2024
@bjw-s @MMichotte
Store migrations statestore in datadir (actualbudget#289)
c161b19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatissJanis MatissJanis MatissJanis approved these changes

Assignees
No one assigned
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: 23.12.0 rootless migrate permission error
2 participants
@bjw-s @MatissJanis