Skip to content

Commit

Permalink
Changed fintro specific bank integration to work with BNP and Hello B…
Browse files Browse the repository at this point in the history
…ank (#285)
  • Loading branch information
feliciaan authored Dec 1, 2023
1 parent dc47c6d commit bb07652
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 4 deletions.
4 changes: 2 additions & 2 deletions src/app-gocardless/bank-factory.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import IntegrationBank from './banks/integration-bank.js';
import MbankRetailBrexplpw from './banks/mbank-retail-brexplpw.js';
import NorwegianXxNorwnok1 from './banks/norwegian-xx-norwnok1.js';
import SandboxfinanceSfin0000 from './banks/sandboxfinance-sfin0000.js';
import FintroBeGebabebb from './banks/fintro-be-gebabebb.js';
import BnpBeGebabebb from './banks/bnp-be-gebabebb.js';
import DanskeBankDabNO22 from './banks/danskebank-dabno22.js';
import SparNordSpNoDK22 from './banks/sparnord-spnodk22.js';
import Belfius from './banks/belfius_gkccbebb.js';
Expand All @@ -15,7 +15,7 @@ const banks = [
MbankRetailBrexplpw,
SandboxfinanceSfin0000,
NorwegianXxNorwnok1,
FintroBeGebabebb,
BnpBeGebabebb,
DanskeBankDabNO22,
SparNordSpNoDK22,
Belfius,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@ const SORTED_BALANCE_TYPE_LIST = [

/** @type {import('./bank.interface.js').IBank} */
export default {
institutionIds: ['FINTRO_BE_GEBABEBB'],
institutionIds: [
'FINTRO_BE_GEBABEBB',
'HELLO_BE_GEBABEBB',
'BNP_BE_GEBABEBB',
],

normalizeAccount(account) {
return {
Expand All @@ -32,7 +36,7 @@ export default {
};
},

/** FINTRO_BE_GEBABEBB provides a lot of useful information via the 'additionalField'
/** BNP_BE_GEBABEBB provides a lot of useful information via the 'additionalField'
* There does not seem to be a specification of this field, but the following information is contained in its subfields:
* - for pending transactions: the 'atmPosName'
* - for booked transactions: the 'narrative'.
Expand Down
6 changes: 6 additions & 0 deletions upcoming-release-notes/285.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
category: Bugfix
authors: [feliciaan]
---

Fix: add fixes for BNP Paribas Fortis and Hello Bank

0 comments on commit bb07652

Please sign in to comment.