Check SimpleFIN access key format (#485)

actualbudget · Nov 3, 2024 · 879869c · 879869c
1 parent 2cd3c9f
commit 879869c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/app-simplefin/app-simplefin.js b/src/app-simplefin/app-simplefin.js
@@ -266,6 +266,10 @@ function parseAccessKey(accessKey) {
   let username = null;
   let password = null;
   let baseUrl = null;
+  if (!accessKey || !accessKey.match(/^.*\/\/.*:.*@.*$/)) {
+    console.log(`Invalid SimpleFIN access key: ${accessKey}`);
+    throw new Error(`Invalid access key`);
+  }
   [scheme, rest] = accessKey.split('//');
   [auth, rest] = rest.split('@');
   [username, password] = auth.split(':');

diff --git a/upcoming-release-notes/485.md b/upcoming-release-notes/485.md
@@ -0,0 +1,6 @@
+---
+category: Enhancements
+authors: [psybers]
+---
+
+Check if SimpleFIN accessKey is in the correct format.