fix TypeError in GoCardless bnp-be-gebabebb sync (#370)

actualbudget · Jun 16, 2024 · 44ddf21 · 44ddf21
1 parent 62c6a87
commit 44ddf21
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/src/app-gocardless/banks/bnp-be-gebabebb.js b/src/app-gocardless/banks/bnp-be-gebabebb.js
@@ -39,10 +39,10 @@ export default {
           let value = (match[4] || match[5]).trim();
           if (key === 'narrative') {
             // Set narrativeName to the first element in the "narrative" array.
-            creditorNameFromNarrative = value
-              .matchAll(/'([a-zA-Z0-9\s]*)'/g)
-              ?.next()
-              .value[1].trim();
+            let first_value = value.matchAll(/'(.+?)'/g)?.next().value;
+            creditorNameFromNarrative = first_value
+              ? first_value[1].trim()
+              : undefined;
           }
           // Remove square brackets and single quotes and commas
           value = value.replace(/[[\]',]/g, '');

diff --git a/upcoming-release-notes/370.md b/upcoming-release-notes/370.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [vojeroen]
+---
+
+Fix failing GoCardless syncs with a bnp-be-gebabebb account.