fix bug in batch SimpleFIN startDate logic (#504)

actualbudget · Nov 21, 2024 · 30f2149 · 30f2149
1 parent b1bf7ee
commit 30f2149
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/src/app-simplefin/app-simplefin.js b/src/app-simplefin/app-simplefin.js
@@ -210,12 +210,13 @@ function getAccountResponse(results, accountId, startDate) {
       dateToUse = trans.posted;
     }
 
-    newTrans.bookingDate = getDate(new Date(dateToUse * 1000));
-    if (newTrans.bookingDate < startDate) {
+    const transactionDate = new Date(dateToUse * 1000);
+
+    if (transactionDate < startDate) {
       continue;
     }
 
-    newTrans.date = newTrans.bookingDate;
+    newTrans.date = getDate(transactionDate);
     newTrans.payeeName = trans.payee;
     newTrans.remittanceInformationUnstructured = trans.description;
     newTrans.transactionAmount = { amount: trans.amount, currency: 'USD' };

diff --git a/upcoming-release-notes/504.md b/upcoming-release-notes/504.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [matt-fidd]
+---
+
+Fix bug in batch SimpleFIN startDate logic