fix for github auth

src/accounts/openid.js

@@ -170,11 +170,22 @@ export async function loginWithOpenIdFinalize(body) {
   let { code_verifier, return_url } = pendingRequest;
 
   try {
-    const params = { code: body.code, state: body.state };
-    let tokenSet = await client.callback(client.redirect_uris[0], params, {
-      code_verifier,
-      state: body.state,
-    });
+    let tokenSet = null;
+
+    if (!config.authMethod || config.authMethod === 'openid') {
+      const params = { code: body.code, state: body.state };
+      tokenSet = await client.callback(client.redirect_uris[0], params, {
+        code_verifier,
+        state: body.state,
+      });
+    } else {
+      tokenSet = await client.grant({
+        grant_type: 'authorization_code',
+        code: body.code,
+        redirect_uri: client.redirect_uris[0],
+        code_verifier,
+      });
+    }
     const userInfo = await client.userinfo(tokenSet.access_token);
     const identity =
       userInfo.preferred_username ??

src/config-types.ts

@@ -32,6 +32,7 @@ export interface Config {
     client_id: string;
     client_secret: string;
     server_hostname: string;
+    authMethod?: 'openid' | 'oauth2';
   };
   multiuser: boolean;
   token_expiration?: 'never' | 'openid-provider' | number;

upcoming-release-notes/527.md

@@ -3,4 +3,4 @@ category: Enhancements
 authors: [lelemm]
 ---
 
-Commands to enable/disable OpenID from console.
+Commands to enable/disable OpenID from console. Also, enabling to login with oauth2 (for github).