Apply suggestions from code review

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
actualbudget · Nov 11, 2024 · 20d8e40 · 20d8e40
1 parent f730a73
commit 20d8e40
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/accounts/openid.js b/src/accounts/openid.js
@@ -244,6 +244,7 @@ export async function loginWithOpenIdFinalize(body) {
     return { url: `${return_url}/openid-cb?token=${token}` };
   } catch (err) {
     console.error('OpenID grant failed:', err);
-    return { error: 'openid-grant-failed: ' + err };
+    console.error('OpenID grant failed:', err);
+    return { error: 'openid-grant-failed' };
   }
 }
diff --git a/src/app-sync.js b/src/app-sync.js
@@ -246,7 +246,11 @@ app.post('/upload-user-file', async (req, res) => {
         syncVersion: syncFormatVersion,
         name: name,
         encryptMeta: encryptMeta,
-        owner: res.locals.user_id,
+        encryptMeta: encryptMeta,
+        // Ensure user_id exists before setting owner
+        owner: res.locals.user_id || (() => {
+          throw new Error('User ID is required for file creation');
+        })(),
       }),
     );