Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#832/feature map option walking to biking #901

Conversation

GrandSuccess87
Copy link
Contributor

@GrandSuccess87 GrandSuccess87 commented Jun 14, 2024

Contributor checklist


Description

I created a feature branch from main in my forked repo to develop and test locally.

  • Run npm docker compose up --build
  • Navigate to the events page
  • Add two wave points to the map
  • You should see the path outlined for the "foot" route profile
  • The user can now toggle between "foot" and "bike" routing profiles and vice versa
  • Clicking the walking icon, should update the UI to display the bike icon (some CSS missing at the moment for the bike icon :p)
  • Adding two wave points, now results in a path outlined for the "foot" route profile, however; so I can look into this some more or perhaps just create a new ticket for this. I'm thinking the latter (so this isn't delayed), which can also include CSS updates. Let me know which would be best!

Related issue

Copy link
Contributor

github-actions bot commented Jun 14, 2024

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link

netlify bot commented Jun 14, 2024

Deploy Preview for activist-org ready!

Name Link
🔨 Latest commit 2db294c
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/6680a7932efdb50008c7204a
😎 Deploy Preview https://deploy-preview-901--activist-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andrewtavis andrewtavis self-requested a review June 29, 2024 19:07
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the hydration changes merged in the event page is a bit broke, @GrandSuccess87, but this is working :) I updated the icons a bit to match the default ones a bit more, and specifically we needed to call directions.destroy() rather than directions.clear() within the directions profile switch, which then allows us to reassign the directions and lets the new profile take effect 😊 We'll be able to see for sure once we start calculating route durations, but the directions are teal and the image does switch 🙌

This map is getting so cool! 🗺️

@andrewtavis andrewtavis merged commit 971caaf into activist-org:main Jun 30, 2024
6 checks passed
@GrandSuccess87
Copy link
Contributor Author

@andrewtavis That's wonderful news!! I'm so glad it's working 🎉🎉 It looks really nice too, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants