-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#832/feature map option walking to biking #901
#832/feature map option walking to biking #901
Conversation
Thank you for the pull request!The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
✅ Deploy Preview for activist-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the hydration changes merged in the event page is a bit broke, @GrandSuccess87, but this is working :) I updated the icons a bit to match the default ones a bit more, and specifically we needed to call directions.destroy()
rather than directions.clear()
within the directions profile switch, which then allows us to reassign the directions and lets the new profile take effect 😊 We'll be able to see for sure once we start calculating route durations, but the directions are teal and the image does switch 🙌
This map is getting so cool! 🗺️
@andrewtavis That's wonderful news!! I'm so glad it's working 🎉🎉 It looks really nice too, thank you! |
Contributor checklist
Description
I created a feature branch from main in my forked repo to develop and test locally.
npm docker compose up --build
Related issue