Add logos

[vponline]

Why are you adding this icons?

I'm adding/updating this icon(s) because ..

Help us identify yourself

• I'm working/collaborating with the brand directly and they have provided the icons.

Link to the brand guidelines: Volt Design Guidelines

Checklist to add new icons

• All icons have a corresponding entry in db/payment_icons.yml
• I have followed the icon guidelines detailed in the CONTRIBUTING.md file
• I have optimized the icon with SVGO
• I am confident that all icons are clear and easy to read/understand
• I have provided a link to the brand icon’s brand guidelines whenever possible.
• I have attached a screenshot comparison with the example icon provided in guidelines
• I recognize that if my icon is not approved by the Shopify Partners team it may not receive review nor merger.

Attach a screenshot of the icon along side the example Visa icon

[hellicarusprime]

Hi @vponline there is already an HSBC logo available so you don't need to add another one. Please update and I'll review.

[hellicarusprime]

@vponline I noticed that the icons you want to add are missing a visible border. Please refer to this section of our contributing guidelines.

[vponline]

@hellicarusprime fixes have been applied, please check again 🙏

[Lovedanihonjin]

Please revise the SVG files:

You are using an incorrect border radius. The border must have a 2px radius (outside stroke)

[vponline]

Are there any further changes required to get these accepted please?

[dannye0231]

Are there any further changes required to get these accepted please?

@vponline are you able to address the following test failures?

Failure:
PaymentIconTest#test_Every_payment_icon_record_has_a_corresponding_SVG_file [test/unit/payment_icon_test.rb:25]:
Expected false to be truthy.

rails test /home/runner/work/payment_icons/payment_icons/test/unit/payment_icon_test.rb:23

..F

Failure:
PaymentIconTest#test_Every_payment_SVG_meets_accessibility_requirements [test/unit/payment_icon_test.rb:89]:
{:message=>"The 'clip0_39_228' ID should be pi-abn-clip0_39_228 (missing 'pi-' prefix)"}.
Expected /pi-(.*)/ to match "clip0_39_228".

[vponline]

Ok that should be fixed now

[Lydia-shan-git]

Please fix radius on your logo for Sparda-Banken so that it fits within the borders

[vponline]

Please fix radius on your logo for Sparda-Banken so that it fits within the borders

I've removed this logo, please review again.