This repository has been archived by the owner on Nov 16, 2021. It is now read-only.
#395: Ensure that target media bundles are specified in EntityFormProxy operations. #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phenaproxima
suggested changes
Jun 28, 2017
| * The target media bundles. | ||
| */ | ||
| protected function getTargetBundles(FormStateInterface $form_state) { | ||
| $bundles = []; |
There was a problem hiding this comment.
The FileUpload class includes this exact code, in its getForm() method. Can that be changed to call this method?
There was a problem hiding this comment.
I think so. Will make that change when I get a second or two. Thanks.
|
@phenaproxima As the originally linked issue is 404, could you help us if this is fixed in recent Lightning versions or not already? Thanks! |
|
Based on this, at least version 3.104 has a proper fix for this problem. |
|
@AronNovak , The original work was completed here: #370 . |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue: https://github.com/acquia/lightning/issues/395