Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1406: Command documentation markup #1833

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Conversation

danepowell
Copy link
Contributor

@danepowell danepowell commented Nov 21, 2024

Motivation

Fixes CLI-1406

Proposed changes

Alternatives considered

Ideally we'd fix or extend the JsonDescriptor instead of handling this in post-processing. Unfortunately, all the JsonDescriptor methods are private and the Descriptor base class is marked as internal.

Testing steps

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. If running from source, clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. Check for regressions: (add specific steps for this pr)
  4. Check new functionality: (add specific steps for this pr)

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.91%. Comparing base (449792d) to head (e66aa57).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1833      +/-   ##
============================================
+ Coverage     92.62%   92.91%   +0.28%     
  Complexity     1843     1843              
============================================
  Files           123      123              
  Lines          6959     6960       +1     
============================================
+ Hits           6446     6467      +21     
+ Misses          513      493      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1833/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1833/acli.phar
chmod +x acli.phar

@danepowell danepowell marked this pull request as ready for review November 26, 2024 22:17
@danepowell danepowell merged commit e0e069f into acquia:main Nov 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant