Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1365: Warn when logs need to be created #1832

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

danepowell
Copy link
Contributor

@danepowell danepowell commented Nov 19, 2024

Motivation

Fixes CLI-1365

Proposed changes

Alternatives considered

Testing steps

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. If running from source, clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. Check for regressions: (add specific steps for this pr)
  4. Check new functionality: (add specific steps for this pr)

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.66%. Comparing base (7298135) to head (8f34804).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1832      +/-   ##
============================================
+ Coverage     92.64%   92.66%   +0.01%     
- Complexity     1837     1839       +2     
============================================
  Files           123      123              
  Lines          6952     6954       +2     
============================================
+ Hits           6441     6444       +3     
+ Misses          511      510       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1832/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1832/acli.phar
chmod +x acli.phar

@@ -96,10 +100,6 @@ public function onConsoleError(ConsoleErrorEvent $event): void
}
}

if ($error instanceof \TypeError && str_contains($error->getMessage(), 'AcquiaCloudApi\Response')) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type errors should not be tolerated: typhonius/acquia-php-sdk-v2#477

@danepowell danepowell marked this pull request as ready for review November 19, 2024 22:59
@danepowell danepowell merged commit 10027cb into acquia:main Nov 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant